Skip to content

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Oct 5, 2025

Was checking on this, and since other CNCF projects, what I checked at the end has this header, adding here too.

  • Adds license headers to source files.
  • automatically adds the license header on project build to the new source file
  • checks for the missing header in the PRs

Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through all the files, but I assume the header is the same everywher.

@csviri
Copy link
Collaborator Author

csviri commented Oct 7, 2025

I didn't go through all the files, but I assume the header is the same everywher.

yes, using the plugin to add it.

@metacosm
Copy link
Collaborator

metacosm commented Oct 8, 2025

I would prefer we do that for the next minor release, rather than for the next patch version and only when we're ready to release (i.e. once main and next have been merged) so that we don't lose changes that might not be in both branches.

@csviri
Copy link
Collaborator Author

csviri commented Oct 8, 2025

I would prefer we do that for the next minor release, rather than for the next patch version and only when we're ready to release (i.e. once main and next have been merged) so that we don't lose changes that might not be in both branches.

I'm fine with that, will change the PR.

csviri added 6 commits October 8, 2025 08:50
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri changed the base branch from main to next October 8, 2025 06:51
@csviri
Copy link
Collaborator Author

csviri commented Oct 8, 2025

updated the PR so it targets next. (also generated headers for new source files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants