-
Notifications
You must be signed in to change notification settings - Fork 229
improve: add license headers to source files #2980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go through all the files, but I assume the header is the same everywher.
yes, using the plugin to add it. |
I would prefer we do that for the next minor release, rather than for the next patch version and only when we're ready to release (i.e. once main and next have been merged) so that we don't lose changes that might not be in both branches. |
I'm fine with that, will change the PR. |
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
updated the PR so it targets next. (also generated headers for new source files) |
Was checking on this, and since other CNCF projects, what I checked at the end has this header, adding here too.