Skip to content

Commit 1f82202

Browse files
committed
refactor: unify usage of var keyword and formatting
Signed-off-by: David Sondermann <[email protected]>
1 parent b0a5838 commit 1f82202

File tree

55 files changed

+152
-191
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+152
-191
lines changed

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ public AdmissionController(AdmissionRequestHandler admissionRequestHandler) {
2525

2626
public AdmissionReview handle(AdmissionReview admissionReview) {
2727
var response = admissionRequestHandler.handle(admissionReview.getRequest());
28-
AdmissionReview responseAdmissionReview = new AdmissionReview();
28+
var responseAdmissionReview = new AdmissionReview();
2929
responseAdmissionReview.setResponse(response);
3030
response.setUid(admissionReview.getRequest().getUid());
3131
return responseAdmissionReview;
3232
}
33-
3433
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionRequestHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,4 @@
66
public interface AdmissionRequestHandler {
77

88
AdmissionResponse handle(AdmissionRequest admissionRequest);
9-
109
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionUtils.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ private AdmissionUtils() {}
1919

2020
public static AdmissionResponse notAllowedExceptionToAdmissionResponse(
2121
NotAllowedException notAllowedException) {
22-
AdmissionResponse admissionResponse = new AdmissionResponse();
22+
var admissionResponse = new AdmissionResponse();
2323
admissionResponse.setAllowed(false);
2424
admissionResponse.setStatus(notAllowedException.getStatus());
2525
return admissionResponse;
@@ -33,17 +33,16 @@ public static KubernetesResource getTargetResource(AdmissionRequest admissionReq
3333

3434
public static AdmissionResponse admissionResponseFromMutation(KubernetesResource originalResource,
3535
KubernetesResource mutatedResource) {
36-
AdmissionResponse admissionResponse = new AdmissionResponse();
36+
var admissionResponse = new AdmissionResponse();
3737
admissionResponse.setAllowed(true);
3838
admissionResponse.setPatchType(JSON_PATCH);
3939
var originalResNode = mapper.valueToTree(originalResource);
4040
var mutatedResNode = mapper.valueToTree(mutatedResource);
4141

4242
var diff = JsonDiff.asJson(originalResNode, mutatedResNode);
43-
String base64Diff =
43+
var base64Diff =
4444
Base64.getEncoder().encodeToString(diff.toString().getBytes(StandardCharsets.UTF_8));
4545
admissionResponse.setPatch(base64Diff);
4646
return admissionResponse;
4747
}
48-
4948
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/AsyncAdmissionController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ public AsyncAdmissionController(AsyncAdmissionRequestHandler requestHandler) {
2828
public CompletionStage<AdmissionReview> handle(AdmissionReview admissionReview) {
2929
return requestHandler.handle(admissionReview.getRequest())
3030
.thenApply(r -> {
31-
AdmissionReview responseAdmissionReview = new AdmissionReview();
31+
var responseAdmissionReview = new AdmissionReview();
3232
responseAdmissionReview.setResponse(r);
3333
r.setUid(admissionReview.getRequest().getUid());
3434
return responseAdmissionReview;
3535
});
3636
}
37-
3837
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/AsyncAdmissionRequestHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@
88
public interface AsyncAdmissionRequestHandler {
99

1010
CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionRequest);
11-
1211
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/AsyncDefaultAdmissionRequestMutator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public AsyncDefaultAdmissionRequestMutator(AsyncMutator<T> mutator, Cloner<T> cl
3333

3434
@Override
3535
public CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionRequest) {
36-
Operation operation = Operation.valueOf(admissionRequest.getOperation());
36+
var operation = Operation.valueOf(admissionRequest.getOperation());
3737
var originalResource = (T) getTargetResource(admissionRequest, operation);
3838
var clonedResource = cloner.clone(originalResource);
3939
CompletionStage<AdmissionResponse> admissionResponse;
@@ -47,5 +47,4 @@ public CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionReque
4747
}
4848
return admissionResponse;
4949
}
50-
5150
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/AsyncMutator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,4 @@
99
public interface AsyncMutator<T extends KubernetesResource> {
1010

1111
CompletionStage<T> mutate(T resource, Operation operation) throws NotAllowedException;
12-
1312
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/DefaultAdmissionRequestMutator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public DefaultAdmissionRequestMutator(Mutator<T> mutator, Cloner<T> cloner) {
3030

3131
@Override
3232
public AdmissionResponse handle(AdmissionRequest admissionRequest) {
33-
Operation operation = Operation.valueOf(admissionRequest.getOperation());
33+
var operation = Operation.valueOf(admissionRequest.getOperation());
3434
var originalResource = (T) getTargetResource(admissionRequest, operation);
3535
var clonedResource = cloner.clone(originalResource);
3636
AdmissionResponse admissionResponse;
@@ -42,5 +42,4 @@ public AdmissionResponse handle(AdmissionRequest admissionRequest) {
4242
}
4343
return admissionResponse;
4444
}
45-
4645
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/Mutator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@
1212
public interface Mutator<T extends KubernetesResource> {
1313

1414
T mutate(T resource, Operation operation) throws NotAllowedException;
15-
1615
}

core/src/main/java/io/javaoperatorsdk/webhook/admission/validation/AsyncDefaultAdmissionRequestValidator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public AsyncDefaultAdmissionRequestValidator(Validator<T> validator) {
2626
@Override
2727
@SuppressWarnings("unchecked")
2828
public CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionRequest) {
29-
Operation operation = Operation.valueOf(admissionRequest.getOperation());
29+
var operation = Operation.valueOf(admissionRequest.getOperation());
3030
var originalResource = (T) getTargetResource(admissionRequest, operation);
3131

3232
var asyncValidate =

0 commit comments

Comments
 (0)