refactor: unify usage of var keyword and formatting

Signed-off-by: David Sondermann <[email protected]>

Author: Donnerbart

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionController.java

@@ -25,10 +25,9 @@ public AdmissionController(AdmissionRequestHandler admissionRequestHandler) {
 
   public AdmissionReview handle(AdmissionReview admissionReview) {
     var response = admissionRequestHandler.handle(admissionReview.getRequest());
-    AdmissionReview responseAdmissionReview = new AdmissionReview();
+    var responseAdmissionReview = new AdmissionReview();
     responseAdmissionReview.setResponse(response);
     response.setUid(admissionReview.getRequest().getUid());
     return responseAdmissionReview;
   }
-
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionControllerException.java

@@ -2,7 +2,8 @@
 
 public class AdmissionControllerException extends RuntimeException {
 
-  public AdmissionControllerException() {}
+  public AdmissionControllerException() {
+  }
 
   public AdmissionControllerException(String message) {
     super(message);

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionRequestHandler.java

@@ -6,5 +6,4 @@
 public interface AdmissionRequestHandler {
 
   AdmissionResponse handle(AdmissionRequest admissionRequest);
-
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/AdmissionUtils.java

@@ -3,23 +3,23 @@
 import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
 import io.fabric8.kubernetes.api.model.KubernetesResource;
 import io.fabric8.kubernetes.api.model.admission.v1.AdmissionRequest;
 import io.fabric8.kubernetes.api.model.admission.v1.AdmissionResponse;
 import io.fabric8.zjsonpatch.JsonDiff;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-
 public class AdmissionUtils {
 
   public static final String JSON_PATCH = "JSONPatch";
   private static final ObjectMapper mapper = new ObjectMapper();
 
-  private AdmissionUtils() {}
+  private AdmissionUtils() {
+  }
 
   public static AdmissionResponse notAllowedExceptionToAdmissionResponse(
       NotAllowedException notAllowedException) {
-    AdmissionResponse admissionResponse = new AdmissionResponse();
+    var admissionResponse = new AdmissionResponse();
     admissionResponse.setAllowed(false);
     admissionResponse.setStatus(notAllowedException.getStatus());
     return admissionResponse;
@@ -33,17 +33,16 @@ public static KubernetesResource getTargetResource(AdmissionRequest admissionReq
 
   public static AdmissionResponse admissionResponseFromMutation(KubernetesResource originalResource,
       KubernetesResource mutatedResource) {
-    AdmissionResponse admissionResponse = new AdmissionResponse();
+    var admissionResponse = new AdmissionResponse();
     admissionResponse.setAllowed(true);
     admissionResponse.setPatchType(JSON_PATCH);
     var originalResNode = mapper.valueToTree(originalResource);
     var mutatedResNode = mapper.valueToTree(mutatedResource);
 
     var diff = JsonDiff.asJson(originalResNode, mutatedResNode);
-    String base64Diff =
+    var base64Diff =
         Base64.getEncoder().encodeToString(diff.toString().getBytes(StandardCharsets.UTF_8));
     admissionResponse.setPatch(base64Diff);
     return admissionResponse;
   }
-
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/AsyncAdmissionController.java

@@ -28,11 +28,10 @@ public AsyncAdmissionController(AsyncAdmissionRequestHandler requestHandler) {
   public CompletionStage<AdmissionReview> handle(AdmissionReview admissionReview) {
     return requestHandler.handle(admissionReview.getRequest())
         .thenApply(r -> {
-          AdmissionReview responseAdmissionReview = new AdmissionReview();
+          var responseAdmissionReview = new AdmissionReview();
           responseAdmissionReview.setResponse(r);
           r.setUid(admissionReview.getRequest().getUid());
           return responseAdmissionReview;
         });
   }
-
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/AsyncAdmissionRequestHandler.java

@@ -8,5 +8,4 @@
 public interface AsyncAdmissionRequestHandler {
 
   CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionRequest);
-
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/AsyncDefaultAdmissionRequestMutator.java

@@ -48,4 +48,5 @@ public CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionReque
     return admissionResponse;
   }
 
+    final var operation = Operation.valueOf(admissionRequest.getOperation());
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/AsyncMutator.java

@@ -9,5 +9,4 @@
 public interface AsyncMutator<T extends KubernetesResource> {
 
   CompletionStage<T> mutate(T resource, Operation operation) throws NotAllowedException;
-
 }

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/DefaultAdmissionRequestMutator.java

@@ -30,7 +30,7 @@ public DefaultAdmissionRequestMutator(Mutator<T> mutator, Cloner<T> cloner) {
 
   @Override
   public AdmissionResponse handle(AdmissionRequest admissionRequest) {
-    Operation operation = Operation.valueOf(admissionRequest.getOperation());
+    var operation = Operation.valueOf(admissionRequest.getOperation());
     var originalResource = (T) getTargetResource(admissionRequest, operation);
     var clonedResource = cloner.clone(originalResource);
     AdmissionResponse admissionResponse;

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/Mutator.java

@@ -12,5 +12,4 @@
 public interface Mutator<T extends KubernetesResource> {
 
   T mutate(T resource, Operation operation) throws NotAllowedException;
-
 }