Skip to content

Commit ef65577

Browse files
committed
refactor: make EndToEndTestBase a proper abstract class
Signed-off-by: David Sondermann <[email protected]>
1 parent 6b9a484 commit ef65577

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

samples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/EndToEndTestBase.java renamed to samples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/AbstractEndToEndTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import static org.junit.jupiter.api.Assertions.assertThrows;
2424

2525
@SuppressWarnings("deprecation")
26-
public class EndToEndTestBase {
26+
public abstract class AbstractEndToEndTest {
2727

2828
protected KubernetesClient client = new KubernetesClientBuilder().build();
2929

samples/quarkus/src/test/java/io/javaoperatorsdk/webhook/sample/QuarkusWebhooksE2E.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import static io.javaoperatorsdk.webhook.sample.commons.Utils.addConversionHookEndpointToCustomResource;
1111
import static io.javaoperatorsdk.webhook.sample.commons.Utils.applyAndWait;
1212

13-
class QuarkusWebhooksE2E extends EndToEndTestBase {
13+
class QuarkusWebhooksE2E extends AbstractEndToEndTest {
1414

1515
@BeforeAll
1616
static void deployService() throws IOException {

samples/spring-boot/src/test/java/io/javaoperatorsdk/webhook/sample/springboot/SpringBootWebhooksE2E.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@
66
import org.junit.jupiter.api.BeforeAll;
77

88
import io.fabric8.kubernetes.client.KubernetesClientBuilder;
9+
import io.javaoperatorsdk.webhook.sample.AbstractEndToEndTest;
910

1011
import static io.javaoperatorsdk.webhook.sample.commons.Utils.addConversionHookEndpointToCustomResource;
1112
import static io.javaoperatorsdk.webhook.sample.commons.Utils.applyAndWait;
1213

13-
class SpringBootWebhooksE2E extends EndToEndTestBase {
14+
class SpringBootWebhooksE2E extends AbstractEndToEndTest {
1415

1516
@BeforeAll
1617
static void deployService() throws IOException {

0 commit comments

Comments
 (0)