(fix) Remove "Serving" condition type from ConditionSets (#1859)

conditionset.ConditionTypes was being used by the CluterExtension
controller to `ensureAllConditionsWithReason` whenever a particular
reason needed to be set for all of the ClusterExention's conditions.
However, the `ConditionTypes` included a Condition Type `Serving`, which
is not a ClusterExtension Condition(it is a ClusterCatalog condition).

This is causing the `Serving` condition to show up when a resolution fails,
which is incorrect to begin with, and is then never cleared when the resolution
succeeds at a later stage.

```
try to upgrade ClusterExtension to a non-exist version
$ kubectl patch ClusterExtension extension-77972 -p '{"spec":{"source":{"catalog":{"version":"0.2.0"}}}}' --type=merge
clusterextension.olm.operatorframework.io/extension-77972 patched

- lastTransitionTime: "2025-03-04T07:16:27Z"
    message: 'error upgrading from currently installed version "0.1.0": no bundles
      found for package "nginx77972" matching version "0.2.0"'
    observedGeneration: 2
    reason: Retrying
    status: "True"
    type: Progressing
  - lastTransitionTime: "2025-03-04T07:16:35Z"
    message: 'error upgrading from currently installed version "0.1.0": no bundles
      found for package "nginx77972" matching version "0.2.0"'
    observedGeneration: 2
    reason: Failed
    status: "False"
    type: Serving
  install:
    bundle:
      name: nginx77972.v0.1.0
      version: 0.1.0
```

This PR removes the `Serving` condition type from `conditonSets.ConditionType`

Author: anik120

api/v1/clustercatalog_types.go

@@ -34,6 +34,14 @@ const (
 
 	AvailabilityModeAvailable   AvailabilityMode = "Available"
 	AvailabilityModeUnavailable AvailabilityMode = "Unavailable"
+
+	// Condition types
+	TypeServing = "Serving"
+
+	// Serving Reasons
+	ReasonAvailable                = "Available"
+	ReasonUnavailable              = "Unavailable"
+	ReasonUserSpecifiedUnavailable = "UserSpecifiedUnavailable"
 )
 
 //+kubebuilder:object:root=true

api/v1/clusterextension_types_test.go

@@ -5,7 +5,6 @@ import (
 	"go/ast"
 	"go/parser"
 	"go/token"
-	"io/fs"
 	"strconv"
 	"strings"
 	"testing"
@@ -52,49 +51,47 @@ func TestClusterExtensionReasonRegistration(t *testing.T) {
 	}
 }
 
-// parseConstants parses the values of the top-level constants in the current
-// directory whose names start with the given prefix. When running as part of a
-// test, the current directory is the directory of the file that contains the
-// test in which this function is called.
+// parseConstants parses the values of the top-level constants that start with the given prefix,
+// in the files clusterextension_types.go and common_types.go.
 func parseConstants(prefix string) ([]string, error) {
 	fset := token.NewFileSet()
-	// ParseDir returns a map of package name to package ASTs. An AST is a representation of the source code
-	// that can be traversed to extract information. The map is keyed by the package name.
-	pkgs, err := parser.ParseDir(fset, ".", func(info fs.FileInfo) bool {
-		return !strings.HasSuffix(info.Name(), "_test.go")
-	}, 0)
-	if err != nil {
-		return nil, err
+	// An AST is a representation of the source code that can be traversed to extract information.
+	// Converting files to AST representation to extract information.
+	parseFiles, astFiles := []string{"clusterextension_types.go", "common_types.go"}, []*ast.File{}
+	for _, file := range parseFiles {
+		p, err := parser.ParseFile(fset, file, nil, 0)
+		if err != nil {
+			return nil, err
+		}
+		astFiles = append(astFiles, p)
 	}
 
 	var constValues []string
 
-	// Iterate all of the top-level declarations in each package's files,
-	// looking for constants that start with the prefix. When we find one,
-	// add its value to the constValues list.
-	for _, pkg := range pkgs {
-		for _, f := range pkg.Files {
-			for _, d := range f.Decls {
-				genDecl, ok := d.(*ast.GenDecl)
-				if !ok {
+	// Iterate all of the top-level declarations in each file, looking
+	// for constants that start with the prefix. When we find one, add
+	// its value to the constValues list.
+	for _, f := range astFiles {
+		for _, d := range f.Decls {
+			genDecl, ok := d.(*ast.GenDecl)
+			if !ok {
+				continue
+			}
+			for _, s := range genDecl.Specs {
+				valueSpec, ok := s.(*ast.ValueSpec)
+				if !ok || len(valueSpec.Names) != 1 || valueSpec.Names[0].Obj.Kind != ast.Con || !strings.HasPrefix(valueSpec.Names[0].String(), prefix) {
 					continue
 				}
-				for _, s := range genDecl.Specs {
-					valueSpec, ok := s.(*ast.ValueSpec)
-					if !ok || len(valueSpec.Names) != 1 || valueSpec.Names[0].Obj.Kind != ast.Con || !strings.HasPrefix(valueSpec.Names[0].String(), prefix) {
+				for _, val := range valueSpec.Values {
+					lit, ok := val.(*ast.BasicLit)
+					if !ok || lit.Kind != token.STRING {
 						continue
 					}
-					for _, val := range valueSpec.Values {
-						lit, ok := val.(*ast.BasicLit)
-						if !ok || lit.Kind != token.STRING {
-							continue
-						}
-						v, err := strconv.Unquote(lit.Value)
-						if err != nil {
-							return nil, fmt.Errorf("unquote literal string %s: %v", lit.Value, err)
-						}
-						constValues = append(constValues, v)
+					v, err := strconv.Unquote(lit.Value)
+					if err != nil {
+						return nil, fmt.Errorf("unquote literal string %s: %v", lit.Value, err)
 					}
+					constValues = append(constValues, v)
 				}
 			}
 		}

api/v1/common_types.go

@@ -19,7 +19,6 @@ package v1
 const (
 	TypeInstalled   = "Installed"
 	TypeProgressing = "Progressing"
-	TypeServing     = "Serving"
 
 	// Progressing reasons
 	ReasonSucceeded = "Succeeded"
@@ -29,9 +28,4 @@ const (
 	// Terminal reasons
 	ReasonDeprecated = "Deprecated"
 	ReasonFailed     = "Failed"
-
-	// Serving reasons
-	ReasonAvailable                = "Available"
-	ReasonUnavailable              = "Unavailable"
-	ReasonUserSpecifiedUnavailable = "UserSpecifiedUnavailable"
 )

internal/operator-controller/conditionsets/conditionsets.go

@@ -31,7 +31,6 @@ var ConditionTypes = []string{
 	ocv1.TypeChannelDeprecated,
 	ocv1.TypeBundleDeprecated,
 	ocv1.TypeProgressing,
-	ocv1.TypeServing,
 }
 
 var ConditionReasons = []string{
@@ -40,7 +39,4 @@ var ConditionReasons = []string{
 	ocv1.ReasonFailed,
 	ocv1.ReasonBlocked,
 	ocv1.ReasonRetrying,
-	ocv1.ReasonAvailable,
-	ocv1.ReasonUnavailable,
-	ocv1.ReasonUserSpecifiedUnavailable,
 }