remove e2e add unit

Signed-off-by: rashmi_kh <[email protected]>

Author: rashmi43

internal/authentication/tokengetter_test.go

@@ -72,13 +72,15 @@ func TestTokenGetterGet(t *testing.T) {
 			"test-namespace-3", "test-token-3", "failed to get token"},
 		{"Testing error when getting token from fake client", "test-service-account-4",
 			"test-namespace-4", "error when fetching token", "error when fetching token"},
+		{"Testing service account not found", "missing-sa",
+			"test-namespace-5", "", "service account \"missing-sa\" not found in namespace \"test-namespace-5\": unable to authenticate with the Kubernetes cluster."},
 	}
 
 	for _, tc := range tests {
 		got, err := tg.Get(context.Background(), types.NamespacedName{Namespace: tc.namespace, Name: tc.serviceAccountName})
 		if err != nil {
 			t.Logf("%s: expected: %v, got: %v", tc.testName, tc.want, err)
-			assert.EqualError(t, err, tc.errorMsg)
+			assert.EqualError(t, err, tc.errorMsg, "Error message should match expected output")
 		} else {
 			t.Logf("%s: expected: %v, got: %v", tc.testName, tc.want, got)
 			assert.Equal(t, tc.want, got, tc.errorMsg)

test/e2e/cluster_extension_install_test.go

@@ -360,71 +360,6 @@ func TestClusterExtensionInstallRegistry(t *testing.T) {
 	}
 }
 
-func TestClusterExtensionInstallFailsWithoutServiceAccount(t *testing.T) {
-	t.Log("When a cluster extension is installed from a catalog")
-	t.Log("And the ServiceAccount does not exist")
-
-	// Step 1: Setup test environment without creating an SA
-	clusterExtensionName := fmt.Sprintf("clusterextension-%s", rand.String(8))
-
-	ns, err := createNamespace(context.Background(), clusterExtensionName)
-	require.NoError(t, err)
-
-	extensionCatalog, err := createTestCatalog(context.Background(), testCatalogName, os.Getenv(testCatalogRefEnvVar))
-	require.NoError(t, err)
-
-	// Important: We do NOT create a ServiceAccount here
-	defer testCleanup(t, extensionCatalog, nil, nil, ns)
-	defer utils.CollectTestArtifacts(t, artifactName, c, cfg)
-
-	// Step 2: Define the ClusterExtension with a non-existent SA
-	clusterExtension := &ocv1.ClusterExtension{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: clusterExtensionName,
-		},
-		Spec: ocv1.ClusterExtensionSpec{
-			Source: ocv1.SourceConfig{
-				SourceType: "Catalog",
-				Catalog: &ocv1.CatalogSource{
-					PackageName: "test",
-					Selector: &metav1.LabelSelector{
-						MatchLabels: map[string]string{"olm.operatorframework.io/metadata.name": extensionCatalog.Name},
-					},
-				},
-			},
-			Namespace: ns.Name,
-			ServiceAccount: ocv1.ServiceAccountReference{
-				Name: "non-existent-sa", // This SA does NOT exist
-			},
-		},
-	}
-
-	t.Log("By creating the ClusterExtension resource without a ServiceAccount")
-	require.NoError(t, c.Create(context.Background(), clusterExtension))
-
-	// Step 3: Validate failure due to missing ServiceAccount
-	t.Log("By eventually reporting an installation failure due to missing ServiceAccount")
-	require.EventuallyWithT(t, func(ct *assert.CollectT) {
-		assert.NoError(ct, c.Get(context.Background(), types.NamespacedName{Name: clusterExtension.Name}, clusterExtension))
-
-		// Validate that Progressing reports failure
-		cond := apimeta.FindStatusCondition(clusterExtension.Status.Conditions, ocv1.TypeProgressing)
-		if assert.NotNil(ct, cond) {
-			assert.Equal(ct, metav1.ConditionTrue, cond.Status)
-			assert.Equal(ct, ocv1.ReasonRetrying, cond.Reason)
-			assert.Contains(ct, cond.Message, "installation cannot proceed due to missing ServiceAccount")
-		}
-
-		// Validate that Installed condition is false
-		installCond := apimeta.FindStatusCondition(clusterExtension.Status.Conditions, ocv1.TypeInstalled)
-		if assert.NotNil(ct, installCond) {
-			assert.Equal(ct, metav1.ConditionUnknown, installCond.Status)
-			assert.Equal(ct, ocv1.ReasonFailed, installCond.Reason)
-			assert.Contains(ct, installCond.Message, "service account")
-		}
-	}, pollDuration, pollInterval)
-}
-
 func TestClusterExtensionInstallRegistryDynamic(t *testing.T) {
 	// NOTE: Like 'TestClusterExtensionInstallRegistry', this test also requires extra configuration in /etc/containers/registries.conf
 	packageName := "dynamic"