Skip to content

Commit 08d3634

Browse files
committed
WIP: fix webhook annotations
Signed-off-by: Todd Short <[email protected]>
1 parent 753907a commit 08d3634

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,10 @@ manifests: $(CONTROLLER_GEN) $(HELM) #EXHELP Generate WebhookConfiguration, Clus
163163
./hack/tools/patch-base-for-helm.sh
164164
# Generate manifests stored in source-control
165165
mkdir -p $(MANIFEST_HOME)
166-
$(HELM) template olmv1 helm/olmv1 > $(STANDARD_MANIFEST)
167-
$(HELM) template olmv1 helm/olmv1 --values helm/e2e.yaml > $(STANDARD_E2E_MANIFEST)
168-
$(HELM) template olmv1 helm/olmv1 --values helm/experimental.yaml > $(EXPERIMENTAL_MANIFEST)
169-
$(HELM) template olmv1 helm/olmv1 --values helm/experimental.yaml --values helm/e2e.yaml > $(EXPERIMENTAL_E2E_MANIFEST)
166+
$(HELM) template olmv1 helm/olmv1 --values helm/standard.yaml > $(STANDARD_MANIFEST)
167+
$(HELM) template olmv1 helm/olmv1 --values helm/standard.yaml --values helm/e2e.yaml > $(STANDARD_E2E_MANIFEST)
168+
$(HELM) template olmv1 helm/olmv1 --values helm/standard.yaml --values helm/experimental.yaml > $(EXPERIMENTAL_MANIFEST)
169+
$(HELM) template olmv1 helm/olmv1 --values helm/standard.yaml --values helm/experimental.yaml --values helm/e2e.yaml > $(EXPERIMENTAL_E2E_MANIFEST)
170170

171171
.PHONY: generate
172172
generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.

helm/olmv1/templates/_helpers.tpl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ olm.operatorframework.io/feature-set: {{ .Values.featureSet -}}{{- if .Values.co
4747
Annotations for Catalogd Webhooks
4848
*/}}
4949
{{- define "olmv1.catalogd.webhook.annotations" -}}
50-
cert-manager.io/inject-ca-from-secret: cert-manager/olmv1-ca
50+
{{- with .Values.components.catalogd.webhook.annotations }}
51+
{{- toYamlPretty . }}
52+
{{- end }}
5153
{{- end }}
5254

5355
{{/*

helm/olmv1/values.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ components:
4747
role:
4848
rules: []
4949
webhook:
50-
annotations:
51-
cert-manager.io/inject-ca-from-secret: cert-manager/olmv1-ca
50+
annotations: {}
5251
certManager:
5352
enabled: true
5453
e2e:

helm/standard.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Default values for OLMv1.
2+
# This is a YAML-formatted file.
3+
# Declare variables to be passed into your templates.
4+
5+
# List of components to include
6+
components:
7+
catalogd:
8+
webhook:
9+
annotations:
10+
cert-manager.io/inject-ca-from-secret: cert-manager/olmv1-ca

0 commit comments

Comments
 (0)