Refactor synthetic auth exported functions

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

internal/operator-controller/authentication/synthetic.go

@@ -8,11 +8,11 @@ import (
 	ocv1 "github.com/operator-framework/operator-controller/api/v1"
 )
 
-func SyntheticUserName(ext ocv1.ClusterExtension) string {
+func syntheticUserName(ext ocv1.ClusterExtension) string {
 	return fmt.Sprintf("olm:clusterextensions:%s", ext.Name)
 }
 
-func SyntheticGroups(_ ocv1.ClusterExtension) []string {
+func syntheticGroups(_ ocv1.ClusterExtension) []string {
 	return []string{
 		"olm:clusterextensions",
 		"system:authenticated",
@@ -21,7 +21,7 @@ func SyntheticGroups(_ ocv1.ClusterExtension) []string {
 
 func SyntheticImpersonationConfig(ext ocv1.ClusterExtension) transport.ImpersonationConfig {
 	return transport.ImpersonationConfig{
-		UserName: SyntheticUserName(ext),
-		Groups:   SyntheticGroups(ext),
+		UserName: syntheticUserName(ext),
+		Groups:   syntheticGroups(ext),
 	}
 }

internal/operator-controller/authentication/synthetic_test.go

@@ -10,23 +10,6 @@ import (
 	"github.com/operator-framework/operator-controller/internal/operator-controller/authentication"
 )
 
-func TestSyntheticUserName(t *testing.T) {
-	syntheticUserName := authentication.SyntheticUserName(ocv1.ClusterExtension{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: "my-ext",
-		},
-	})
-	require.Equal(t, "olm:clusterextensions:my-ext", syntheticUserName)
-}
-
-func TestSyntheticGroups(t *testing.T) {
-	syntheticGroups := authentication.SyntheticGroups(ocv1.ClusterExtension{})
-	require.Equal(t, []string{
-		"olm:clusterextensions",
-		"system:authenticated",
-	}, syntheticGroups)
-}
-
 func TestSyntheticImpersonationConfig(t *testing.T) {
 	config := authentication.SyntheticImpersonationConfig(ocv1.ClusterExtension{
 		ObjectMeta: metav1.ObjectMeta{