remove convert-diff gha and tidy up Makefile

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

.github/workflows/convert-diff.yaml

@@ -151,13 +151,14 @@ generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyI
 	$(CONTROLLER_GEN) --load-build-tags=$(GO_BUILD_TAGS) object:headerFile="hack/boilerplate.go.txt" paths="./..."
 
 .PHONY: verify
-verify: tidy fmt generate manifests crd-ref-docs #HELP Verify all generated code is up-to-date.
+verify: tidy fmt generate manifests crd-ref-docs generate-bundle-manifests #HELP Verify all generated code is up-to-date.
 	git diff --exit-code
 
-.PHONY: verify-convert
-verify-convert:
+# Renders registry+v1 bundles in test/convert
+# Used by CI in verify to catch regressions in the registry+v1 -> plain conversion code
+.PHONY: generate-bundle-manifests
+generate-bundle-manifests:
 	go run test/convert/generate-manifests.go
-	git diff --exit-code
 
 .PHONY: fix-lint
 fix-lint: $(GOLANGCI_LINT) #EXHELP Fix lint issues
@@ -397,17 +398,17 @@ crd-ref-docs: $(CRD_REF_DOCS) #EXHELP Generate the API Reference Documents.
 VENVDIR := $(abspath docs/.venv)
 
 .PHONY: build-docs
-build-docs: venv
+build-docs:
 	. $(VENV)/activate; \
 	mkdocs build
 
 .PHONY: serve-docs
-serve-docs: venv
+serve-docs:
 	. $(VENV)/activate; \
 	mkdocs serve
 
 .PHONY: deploy-docs
-deploy-docs: venv
+deploy-docs:
 	. $(VENV)/activate; \
 	mkdocs gh-deploy --force