add e2e test

Signed-off-by: rashmi_kh <[email protected]>

Author: rashmi43

internal/controllers/clusterextension_controller_test.go

@@ -677,79 +677,6 @@ func TestClusterExtensionInstallationSucceeds(t *testing.T) {
 	require.NoError(t, cl.DeleteAllOf(ctx, &ocv1.ClusterExtension{}))
 }
 
-func TestClusterExtensionInstallationFailsWithNoServiceAccount(t *testing.T) {
-	cl, reconciler := newClientAndReconciler(t)
-	reconciler.Unpacker = &MockUnpacker{
-		result: &source.Result{
-			State:  source.StateUnpacked,
-			Bundle: fstest.MapFS{},
-		},
-	}
-
-	ctx := context.Background()
-	extKey := types.NamespacedName{Name: fmt.Sprintf("cluster-extension-test-%s", rand.String(8))}
-
-	t.Log("When the cluster extension specifies a channel with version that exist")
-	t.Log("By initializing cluster state")
-	pkgName := "prometheus"
-	pkgVer := "1.0.0"
-	pkgChan := "beta"
-	namespace := fmt.Sprintf("test-ns-%s", rand.String(8))
-	serviceAccount := fmt.Sprintf("test-does1-not-exist-%s", rand.String(8))
-
-	clusterExtension := &ocv1.ClusterExtension{
-		ObjectMeta: metav1.ObjectMeta{Name: extKey.Name},
-		Spec: ocv1.ClusterExtensionSpec{
-			Source: ocv1.SourceConfig{
-				SourceType: "Catalog",
-				Catalog: &ocv1.CatalogSource{
-					PackageName: pkgName,
-					Version:     pkgVer,
-					Channels:    []string{pkgChan},
-				},
-			},
-			Namespace: namespace,
-			ServiceAccount: ocv1.ServiceAccountReference{
-				Name: serviceAccount,
-			},
-		},
-	}
-	err := cl.Create(ctx, clusterExtension)
-	require.NoError(t, err)
-
-	t.Log("By fetching updated cluster extension after reconcile")
-	require.NoError(t, cl.Get(ctx, extKey, clusterExtension))
-
-	t.Log("It sets resolution success status")
-	t.Log("By running reconcile")
-	reconciler.Resolver = resolve.Func(func(_ context.Context, _ *ocv1.ClusterExtension, _ *ocv1.BundleMetadata) (*declcfg.Bundle, *bsemver.Version, *declcfg.Deprecation, error) {
-		v := bsemver.MustParse("1.0.0")
-		return &declcfg.Bundle{
-			Name:    "prometheus.v1.0.0",
-			Package: "prometheus",
-			Image:   "quay.io/operatorhubio/[email protected]",
-		}, &v, nil, nil
-	})
-	reconciler.Applier = &MockApplier{
-		objs: []client.Object{},
-	}
-	reconciler.Applier = &MockApplier{
-		err: errors.New("missing ServiceAccount"),
-	}
-	reconciler.Manager = &MockManagedContentCacheManager{
-		cache: &MockManagedContentCache{},
-	}
-
-	_, err = reconciler.Reconcile(ctx, ctrl.Request{NamespacedName: extKey})
-	require.Error(t, err)
-
-	t.Log("By fetching updated cluster extension after reconcile")
-	require.NoError(t, cl.Get(ctx, extKey, clusterExtension))
-
-	t.Log("By checking the status fields")
-	require.Contains(t, err.Error(), "missing ServiceAccount")
-}
-
 func TestClusterExtensionDeleteFinalizerFails(t *testing.T) {
 	cl, reconciler := newClientAndReconciler(t)
 	reconciler.Unpacker = &MockUnpacker{

test/e2e/cluster_extension_install_test.go

@@ -351,6 +351,71 @@ func TestClusterExtensionInstallRegistry(t *testing.T) {
 	}
 }
 
+func TestClusterExtensionInstallFailsWithoutServiceAccount(t *testing.T) {
+	t.Log("When a cluster extension is installed from a catalog")
+	t.Log("And the ServiceAccount does not exist")
+
+	// Step 1: Setup test environment without creating an SA
+	clusterExtensionName := fmt.Sprintf("clusterextension-%s", rand.String(8))
+
+	ns, err := createNamespace(context.Background(), clusterExtensionName)
+	require.NoError(t, err)
+
+	extensionCatalog, err := createTestCatalog(context.Background(), testCatalogName, os.Getenv(testCatalogRefEnvVar))
+	require.NoError(t, err)
+
+	// Important: We do NOT create a ServiceAccount here
+	defer testCleanup(t, extensionCatalog, nil, nil, ns)
+	defer utils.CollectTestArtifacts(t, artifactName, c, cfg)
+
+	// Step 2: Define the ClusterExtension with a non-existent SA
+	clusterExtension := &ocv1.ClusterExtension{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: clusterExtensionName,
+		},
+		Spec: ocv1.ClusterExtensionSpec{
+			Source: ocv1.SourceConfig{
+				SourceType: "Catalog",
+				Catalog: &ocv1.CatalogSource{
+					PackageName: "test",
+					Selector: &metav1.LabelSelector{
+						MatchLabels: map[string]string{"olm.operatorframework.io/metadata.name": extensionCatalog.Name},
+					},
+				},
+			},
+			Namespace: ns.Name,
+			ServiceAccount: ocv1.ServiceAccountReference{
+				Name: "non-existent-sa", // This SA does NOT exist
+			},
+		},
+	}
+
+	t.Log("By creating the ClusterExtension resource without a ServiceAccount")
+	require.NoError(t, c.Create(context.Background(), clusterExtension))
+
+	// Step 3: Validate failure due to missing ServiceAccount
+	t.Log("By eventually reporting an installation failure due to missing ServiceAccount")
+	require.EventuallyWithT(t, func(ct *assert.CollectT) {
+		assert.NoError(ct, c.Get(context.Background(), types.NamespacedName{Name: clusterExtension.Name}, clusterExtension))
+
+		// Validate that Progressing reports failure
+		cond := apimeta.FindStatusCondition(clusterExtension.Status.Conditions, ocv1.TypeProgressing)
+		if assert.NotNil(ct, cond) {
+			assert.Equal(ct, metav1.ConditionTrue, cond.Status)
+			assert.Equal(ct, ocv1.ReasonRetrying, cond.Reason)
+			assert.Contains(ct, cond.Message, "installation cannot proceed due to missing ServiceAccount")
+		}
+
+		// Validate that Installed condition is false
+		installCond := apimeta.FindStatusCondition(clusterExtension.Status.Conditions, ocv1.TypeInstalled)
+		if assert.NotNil(ct, installCond) {
+			assert.Equal(ct, metav1.ConditionUnknown, installCond.Status)
+			assert.Equal(ct, ocv1.ReasonFailed, installCond.Reason)
+			assert.Contains(ct, installCond.Message, "service account")
+		}
+	}, pollDuration, pollInterval)
+}
+
 func TestClusterExtensionInstallRegistryDynamic(t *testing.T) {
 	// NOTE: Like 'TestClusterExtensionInstallRegistry', this test also requires extra configuration in /etc/containers/registries.conf
 	packageName := "dynamic"