Fix a flake in upgrade e2e (#1346)

m1kola · web-flow · commit 8466890be564 · 2024-10-04T11:44:23.000Z
There is a potential for nil pointer dereference in the test.
This change adds condition to check for nil.

Signed-off-by: Mikalai Radchuk &lt;mradchuk@redhat.com&gt;
diff --git a/test/upgrade-e2e/post_upgrade_test.go b/test/upgrade-e2e/post_upgrade_test.go
@@ -86,7 +86,7 @@ func TestClusterExtensionAfterOLMUpgrade(t *testing.T) {
 		assert.Equal(ct, metav1.ConditionTrue, cond.Status)
 		assert.Equal(ct, ocv1alpha1.ReasonSuccess, cond.Reason)
 		assert.Contains(ct, cond.Message, "Installed bundle")
-		if assert.NotEmpty(ct, clusterExtension.Status.Install.Bundle) {
+		if assert.NotNil(ct, clusterExtension.Status.Install) {
 			assert.NotEmpty(ct, clusterExtension.Status.Install.Bundle.Version)
 		}
 	}, time.Minute, time.Second)

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func TestClusterExtensionAfterOLMUpgrade(t *testing.T) {`
`86`	`86`	`assert.Equal(ct, metav1.ConditionTrue, cond.Status)`
`87`	`87`	`assert.Equal(ct, ocv1alpha1.ReasonSuccess, cond.Reason)`
`88`	`88`	`assert.Contains(ct, cond.Message, "Installed bundle")`
`89`		`- if assert.NotEmpty(ct, clusterExtension.Status.Install.Bundle) {`
	`89`	`+ if assert.NotNil(ct, clusterExtension.Status.Install) {`
`90`	`90`	`assert.NotEmpty(ct, clusterExtension.Status.Install.Bundle.Version)`
`91`	`91`	`}`
`92`	`92`	`}, time.Minute, time.Second)`