(bugfix): fix a bug in the containers image source (#1395)

everettraven · web-flow · commit 8a0f25d980fa · 2024-10-18T20:27:19.000Z
where we always pulled image references using the canonical reference.
Now we pull images using the reference provided to the source. Using only
the canonical reference resulted in not respecting some mirroring configurations
related to tags because we never used tag-based references.

Signed-off-by: everettraven &lt;everettraven@gmail.com&gt;
diff --git a/internal/rukpak/source/containers_image.go b/internal/rukpak/source/containers_image.go
@@ -80,7 +80,7 @@ func (i *ContainersImageRegistry) Unpack(ctx context.Context, bundle *BundleSour
 	// copy.Image can concurrently pull all the layers.
 	//
 	//////////////////////////////////////////////////////
-	dockerRef, err := docker.NewReference(canonicalRef)
+	dockerRef, err := docker.NewReference(imgRef)
 	if err != nil {
 		return nil, fmt.Errorf("error creating source reference: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ func (i ContainersImageRegistry) Unpack(ctx context.Context, bundle BundleSour`
`80`	`80`	`// copy.Image can concurrently pull all the layers.`
`81`	`81`	`//`
`82`	`82`	`//////////////////////////////////////////////////////`
`83`		`- dockerRef, err := docker.NewReference(canonicalRef)`
	`83`	`+ dockerRef, err := docker.NewReference(imgRef)`
`84`	`84`	`if err != nil {`
`85`	`85`	`return nil, fmt.Errorf("error creating source reference: %w", err)`
`86`	`86`	`}`