Skip to content

Commit 8cf5bda

Browse files
perdasilvaPer Goncalves da Silva
andauthored
Remove test-operator.v2.0.0 fixture (#2093)
Signed-off-by: Per Goncalves da Silva <[email protected]> Co-authored-by: Per Goncalves da Silva <[email protected]>
1 parent 86e4ce9 commit 8cf5bda

File tree

8 files changed

+16
-220
lines changed

8 files changed

+16
-220
lines changed

test/e2e/cluster_extension_install_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,12 @@ func TestClusterExtensionInstallRegistry(t *testing.T) {
399399
var np networkingv1.NetworkPolicy
400400
require.NoError(ct, c.Get(context.Background(), types.NamespacedName{Name: "test-operator-network-policy", Namespace: ns.Name}, &np))
401401
}, pollDuration, pollInterval)
402+
403+
t.Log("By verifying that no templating occurs for registry+v1 bundle manifests")
404+
cm := corev1.ConfigMap{}
405+
require.NoError(t, c.Get(context.Background(), types.NamespacedName{Namespace: ns.Name, Name: "test-configmap"}, &cm))
406+
require.Contains(t, cm.Annotations, "shouldNotTemplate")
407+
require.Contains(t, cm.Annotations["shouldNotTemplate"], "{{ $labels.namespace }}")
402408
})
403409
}
404410
}
@@ -743,14 +749,8 @@ func TestClusterExtensionInstallReResolvesWhenCatalogIsPatched(t *testing.T) {
743749
require.Equal(ct, metav1.ConditionTrue, cond.Status)
744750
require.Equal(ct, ocv1.ReasonSucceeded, cond.Reason)
745751
require.Contains(ct, cond.Message, "Installed bundle")
746-
require.Contains(ct, clusterExtension.Status.Install.Bundle.Version, "2.0.0")
752+
require.Contains(ct, clusterExtension.Status.Install.Bundle.Version, "1.3.0")
747753
}, pollDuration, pollInterval)
748-
749-
t.Log("By verifying that no templating occurs for registry+v1 bundle manifests")
750-
cm := corev1.ConfigMap{}
751-
require.NoError(t, c.Get(context.Background(), types.NamespacedName{Namespace: ns.Name, Name: "test-configmap"}, &cm))
752-
require.Contains(t, cm.Annotations, "shouldNotTemplate")
753-
require.Contains(t, cm.Annotations["shouldNotTemplate"], "{{ $labels.namespace }}")
754754
}
755755

756756
func TestClusterExtensionInstallReResolvesWhenNewCatalog(t *testing.T) {

testdata/images/bundles/test-operator/v1.0.0/manifests/bundle.configmap.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ apiVersion: v1
22
kind: ConfigMap
33
metadata:
44
name: test-configmap
5+
annotations:
6+
shouldNotTemplate: >
7+
The namespace is {{ $labels.namespace }}. The templated
8+
$labels.namespace is NOT expected to be processed by OLM's
9+
rendering engine for registry+v1 bundles.
510
data:
611
version: "v1.0.0"
712
name: "test-configmap"

testdata/images/bundles/test-operator/v2.0.0/manifests/bundle.configmap.yaml

Lines changed: 0 additions & 12 deletions
This file was deleted.

testdata/images/bundles/test-operator/v2.0.0/manifests/olm.operatorframework.com_olme2etest.yaml

Lines changed: 0 additions & 28 deletions
This file was deleted.

testdata/images/bundles/test-operator/v2.0.0/manifests/testoperator.clusterserviceversion.yaml

Lines changed: 0 additions & 151 deletions
This file was deleted.

testdata/images/bundles/test-operator/v2.0.0/manifests/testoperator.networkpolicy.yaml

Lines changed: 0 additions & 8 deletions
This file was deleted.

testdata/images/bundles/test-operator/v2.0.0/metadata/annotations.yaml

Lines changed: 0 additions & 10 deletions
This file was deleted.

testdata/images/catalogs/test-catalog/v2/configs/catalog.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ schema: olm.channel
77
name: beta
88
package: test
99
entries:
10-
- name: test-operator.2.0.0
10+
- name: test-operator.1.3.0
1111
replaces: test-operator.1.2.0
1212
---
1313
schema: olm.bundle
14-
name: test-operator.2.0.0
14+
name: test-operator.1.3.0
1515
package: test
16-
image: docker-registry.operator-controller-e2e.svc.cluster.local:5000/bundles/registry-v1/test-operator:v2.0.0
16+
image: docker-registry.operator-controller-e2e.svc.cluster.local:5000/bundles/registry-v1/test-operator:v1.0.0
1717
properties:
1818
- type: olm.package
1919
value:
2020
packageName: test
21-
version: 2.0.0
21+
version: 1.3.0

0 commit comments

Comments
 (0)