fix error handling, fix lint issues and tidy go.mod

Signed-off-by: Omar Farag <[email protected]>

Author: o-farag

cmd/operator-controller/main.go

@@ -80,16 +80,16 @@ var (
 )
 
 type config struct {
-	metricsAddr               string
-	certFile                  string
-	keyFile                   string
-	enableLeaderElection      bool
-	probeAddr                 string
-	cachePath                 string
-	systemNamespace           string
-	catalogdCasDir            string
-	pullCasDir                string
-	globalPullSecret          string
+	metricsAddr          string
+	certFile             string
+	keyFile              string
+	enableLeaderElection bool
+	probeAddr            string
+	cachePath            string
+	systemNamespace      string
+	catalogdCasDir       string
+	pullCasDir           string
+	globalPullSecret     string
 }
 
 const authFilePrefix = "operator-controller-global-pull-secrets"
@@ -111,7 +111,7 @@ var operatorControllerCmd = &cobra.Command{
 	Short: "operator-controller is the central component of Operator Lifecycle Manager (OLM) v1",
 	RunE: func(cmd *cobra.Command, args []string) error {
 		if err := validateMetricsFlags(); err != nil {
-			return fmt.Errorf("Error: %v\n", err)
+			return err
 		}
 		return run()
 	},
@@ -126,7 +126,6 @@ var versionCommand = &cobra.Command{
 }
 
 func init() {
-
 	//create flagset, the collection of flags for this command
 	flags := operatorControllerCmd.Flags()
 	flags.StringVar(&cfg.metricsAddr, "metrics-bind-address", "", "The address for the metrics endpoint. Requires tls-cert and tls-key. (Default: ':8443')")
@@ -152,7 +151,6 @@ func init() {
 
 	//add feature gate flags to flagset
 	features.OperatorControllerFeatureGate.AddFlag(flags)
-
 }
 
 func validateMetricsFlags() error {
@@ -474,7 +472,8 @@ func run() error {
 }
 
 func main() {
-
-	operatorControllerCmd.Execute()
-
+	if err := operatorControllerCmd.Execute(); err != nil {
+		fmt.Fprintf(os.Stderr, "Error: %v\n", err)
+		os.Exit(1)
+	}
 }

go.mod

@@ -22,6 +22,7 @@ require (
 	github.com/operator-framework/helm-operator-plugins v0.8.0
 	github.com/operator-framework/operator-registry v1.50.0
 	github.com/prometheus/client_golang v1.20.5
+	github.com/spf13/cobra v1.8.1
 	github.com/spf13/pflag v1.0.6
 	github.com/stretchr/testify v1.10.0
 	golang.org/x/exp v0.0.0-20241009180824-f66d83c29e7c
@@ -197,7 +198,6 @@ require (
 	github.com/sigstore/sigstore v1.8.9 // indirect
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/spf13/cast v1.7.0 // indirect
-	github.com/spf13/cobra v1.8.1 // indirect
 	github.com/stefanberger/go-pkcs11uri v0.0.0-20230803200340-78284954bff6 // indirect
 	github.com/stoewer/go-strcase v1.3.0 // indirect
 	github.com/stretchr/objx v0.5.2 // indirect