Skip to content

Commit adf64a0

Browse files
authored
Remove check-cluster dependency from test-e2e (#473)
`check-cluster` is already a dependency of the `install` targt, which is a dependency of `e2e`. It does not need to be a dependency of `test-e2e` which _just_ runs the tests without any setup. Signed-off-by: Todd Short <[email protected]>
1 parent f7eee6e commit adf64a0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ FOCUS := $(if $(TEST),-v -focus "$(TEST)")
110110
ifeq ($(origin E2E_FLAGS), undefined)
111111
E2E_FLAGS :=
112112
endif
113-
test-e2e: check-cluster $(GINKGO) ## Run the e2e tests on existing cluster
113+
test-e2e: $(GINKGO) ## Run the e2e tests on existing cluster
114114
$(GINKGO) $(E2E_FLAGS) -trace -vv $(FOCUS) test/e2e
115115

116116
e2e: KIND_CLUSTER_NAME := catalogd-e2e
@@ -236,7 +236,7 @@ deploy: $(KUSTOMIZE) ## Deploy Catalogd to the K8s cluster specified in ~/.kube/
236236
$(KUSTOMIZE) build $(KUSTOMIZE_OVERLAY) | sed "s/cert-git-version/cert-$(GIT_VERSION)/g" > catalogd.yaml
237237
envsubst '$$CERT_MGR_VERSION,$$MANIFEST,$$DEFAULT_CATALOGS' < scripts/install.tpl.sh | bash -s
238238

239-
.PHONY: check-cluster only-deploy-manifest
239+
.PHONY: only-deploy-manifest
240240
only-deploy-manifest: $(KUSTOMIZE) ## Deploy just the Catalogd manifest--used in e2e testing where cert-manager is installed in a separate step
241241
cd config/base/manager && $(KUSTOMIZE) edit set image controller=$(IMAGE)
242242
$(KUSTOMIZE) build $(KUSTOMIZE_OVERLAY) | kubectl apply -f -

0 commit comments

Comments
 (0)