replace static test variable

Author: anik120

catalogd/internal/serverutil/serverutil.go

@@ -102,5 +102,4 @@ func storageServerHandlerWrapped(mgr ctrl.Manager, cfg CatalogServerConfig) http
 	l := mgr.GetLogger().WithName("catalogd-http-server")
 	handler = logrLoggingHandler(l, handler)
 	return handler
-
 }

catalogd/internal/serverutil/serverutil_test.go

@@ -7,13 +7,17 @@ import (
 	"io/fs"
 	"net/http"
 	"net/http/httptest"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 	ctrl "sigs.k8s.io/controller-runtime"
 )
 
 func TestStorageServerHandlerWrapped_Gzip(t *testing.T) {
+	var generatedJSON = func(size int) string {
+		return "{\"data\":\"" + strings.Repeat("test data ", size) + "\"}"
+	}
 	tests := []struct {
 		name             string
 		acceptEncoding   string
@@ -24,7 +28,7 @@ func TestStorageServerHandlerWrapped_Gzip(t *testing.T) {
 		{
 			name:             "compresses large response when client accepts gzip",
 			acceptEncoding:   "gzip",
-			responseContent:  testCompressableJSON,
+			responseContent:  generatedJSON(1000),
 			expectCompressed: true,
 			expectedStatus:   http.StatusOK,
 		},
@@ -38,7 +42,7 @@ func TestStorageServerHandlerWrapped_Gzip(t *testing.T) {
 		{
 			name:             "does not compress when client doesn't accept gzip",
 			acceptEncoding:   "",
-			responseContent:  testCompressableJSON,
+			responseContent:  generatedJSON(1000),
 			expectCompressed: false,
 			expectedStatus:   http.StatusOK,
 		},
@@ -96,137 +100,6 @@ func TestStorageServerHandlerWrapped_Gzip(t *testing.T) {
 	}
 }
 
-const testCompressableJSON = `{
-	"defaultChannel": "stable-v6.x",
-	"name": "cockroachdb",
-	"schema": "olm.package"
-  }
-  {
-	"entries": [
-	  {
-		"name": "cockroachdb.v5.0.3"
-	  },
-	  {
-		"name": "cockroachdb.v5.0.4",
-		"replaces": "cockroachdb.v5.0.3"
-	  }
-	],
-	"name": "stable-5.x",
-	"package": "cockroachdb",
-	"schema": "olm.channel"
-  }
-  {
-	"entries": [
-	  {
-		"name": "cockroachdb.v6.0.0",
-		"skipRange": "<6.0.0"
-	  }
-	],
-	"name": "stable-v6.x",
-	"package": "cockroachdb",
-	"schema": "olm.channel"
-  }
-  {
-	"image": "quay.io/openshift-community-operators/cockroachdb@sha256:a5d4f4467250074216eb1ba1c36e06a3ab797d81c431427fc2aca97ecaf4e9d8",
-	"name": "cockroachdb.v5.0.3",
-	"package": "cockroachdb",
-	"properties": [
-	  {
-		"type": "olm.gvk",
-		"value": {
-		  "group": "charts.operatorhub.io",
-		  "kind": "Cockroachdb",
-		  "version": "v1alpha1"
-		}
-	  },
-	  {
-		"type": "olm.package",
-		"value": {
-		  "packageName": "cockroachdb",
-		  "version": "5.0.3"
-		}
-	  }
-	],
-	"relatedImages": [
-	  {
-		"name": "",
-		"image": "quay.io/helmoperators/cockroachdb:v5.0.3"
-	  },
-	  {
-		"name": "",
-		"image": "quay.io/openshift-community-operators/cockroachdb@sha256:a5d4f4467250074216eb1ba1c36e06a3ab797d81c431427fc2aca97ecaf4e9d8"
-	  }
-	],
-	"schema": "olm.bundle"
-  }
-  {
-	"image": "quay.io/openshift-community-operators/cockroachdb@sha256:f42337e7b85a46d83c94694638e2312e10ca16a03542399a65ba783c94a32b63",
-	"name": "cockroachdb.v5.0.4",
-	"package": "cockroachdb",
-	"properties": [
-	  {
-		"type": "olm.gvk",
-		"value": {
-		  "group": "charts.operatorhub.io",
-		  "kind": "Cockroachdb",
-		  "version": "v1alpha1"
-		}
-	  },
-	  {
-		"type": "olm.package",
-		"value": {
-		  "packageName": "cockroachdb",
-		  "version": "5.0.4"
-		}
-	  }
-	],
-	"relatedImages": [
-	  {
-		"name": "",
-		"image": "quay.io/helmoperators/cockroachdb:v5.0.4"
-	  },
-	  {
-		"name": "",
-		"image": "quay.io/openshift-community-operators/cockroachdb@sha256:f42337e7b85a46d83c94694638e2312e10ca16a03542399a65ba783c94a32b63"
-	  }
-	],
-	"schema": "olm.bundle"
-  }
-  {
-	"image": "quay.io/openshift-community-operators/cockroachdb@sha256:d3016b1507515fc7712f9c47fd9082baf9ccb070aaab58ed0ef6e5abdedde8ba",
-	"name": "cockroachdb.v6.0.0",
-	"package": "cockroachdb",
-	"properties": [
-	  {
-		"type": "olm.gvk",
-		"value": {
-		  "group": "charts.operatorhub.io",
-		  "kind": "Cockroachdb",
-		  "version": "v1alpha1"
-		}
-	  },
-	  {
-		"type": "olm.package",
-		"value": {
-		  "packageName": "cockroachdb",
-		  "version": "6.0.0"
-		}
-	  }
-	],
-	"relatedImages": [
-	  {
-		"name": "",
-		"image": "quay.io/cockroachdb/cockroach-helm-operator:6.0.0"
-	  },
-	  {
-		"name": "",
-		"image": "quay.io/openshift-community-operators/cockroachdb@sha256:d3016b1507515fc7712f9c47fd9082baf9ccb070aaab58ed0ef6e5abdedde8ba"
-	  }
-	],
-	"schema": "olm.bundle"
-  }
-  `
-
 // mockStorageInstance implements storage.Instance interface for testing
 type mockStorageInstance struct {
 	content string