Skip to content

Commit da0e803

Browse files
fix install script and release to use and provide default-catalog (#1675)
1 parent 3998a3b commit da0e803

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.goreleaser.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ release:
124124
disable: '{{ ne .Env.ENABLE_RELEASE_PIPELINE "true" }}'
125125
extra_files:
126126
- glob: 'operator-controller.yaml'
127+
- glob: './catalogd/config/base/default/clustercatalogs/default-catalogs.yaml'
127128
- glob: 'install.sh'
128129
header: |
129130
## Installation

Makefile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,10 @@ kind-load: $(KIND) #EXHELP Loads the currently constructed images into the KIND
248248

249249
.PHONY: kind-deploy
250250
kind-deploy: export MANIFEST := ./operator-controller.yaml
251+
kind-deploy: export DEFAULT_CATALOG := ./catalogd/config/base/default/clustercatalogs/default-catalogs.yaml
251252
kind-deploy: manifests $(KUSTOMIZE)
252253
($(KUSTOMIZE) build $(KUSTOMIZE_BUILD_DIR) && echo "---" && $(KUSTOMIZE) build catalogd/config/overlays/cert-manager | sed "s/cert-git-version/cert-$(VERSION)/g") > $(MANIFEST)
253-
envsubst '$$CERT_MGR_VERSION,$$INSTALL_DEFAULT_CATALOGS,$$MANIFEST' < scripts/install.tpl.sh | bash -s
254+
envsubst '$$DEFAULT_CATALOG,$$CERT_MGR_VERSION,$$INSTALL_DEFAULT_CATALOGS,$$MANIFEST' < scripts/install.tpl.sh | bash -s
254255

255256

256257
.PHONY: kind-cluster
@@ -329,9 +330,10 @@ release: $(GORELEASER) #EXHELP Runs goreleaser for the operator-controller. By d
329330

330331
.PHONY: quickstart
331332
quickstart: export MANIFEST := https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/operator-controller.yaml
333+
quickstart: export DEFAULT_CATALOG := "https://github.com/operator-framework/operator-controller/releases/download/$(VERSION)/default-catalogs.yaml"
332334
quickstart: $(KUSTOMIZE) manifests #EXHELP Generate the unified installation release manifests and scripts.
333335
($(KUSTOMIZE) build $(KUSTOMIZE_BUILD_DIR) && echo "---" && $(KUSTOMIZE) build catalogd/config/overlays/cert-manager) | sed "s/cert-git-version/cert-$(VERSION)/g" | sed "s/:devel/:$(VERSION)/g" > operator-controller.yaml
334-
envsubst '$$CERT_MGR_VERSION,$$INSTALL_DEFAULT_CATALOGS,$$MANIFEST' < scripts/install.tpl.sh > install.sh
336+
envsubst '$$DEFAULT_CATALOG,$$CERT_MGR_VERSION,$$INSTALL_DEFAULT_CATALOGS,$$MANIFEST' < scripts/install.tpl.sh > install.sh
335337

336338
##@ Docs
337339

scripts/install.tpl.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ if [[ -z "$olmv1_manifest" ]]; then
99
exit 1
1010
fi
1111

12-
default_catalogs_manifest="./catalogd/config/base/default/clustercatalogs/default-catalogs.yaml"
12+
default_catalogs_manifest=$DEFAULT_CATALOG
1313
cert_mgr_version=$CERT_MGR_VERSION
1414
install_default_catalogs=$INSTALL_DEFAULT_CATALOGS
1515

0 commit comments

Comments
 (0)