Fix lint prealloc err on allMissingPolicyRules

bentito · bentito · commit db7e7409855a · 2025-04-11T09:18:11.000-04:00
Signed-off-by: Brett Tofel &lt;btofel@redhat.com&gt;
diff --git a/internal/operator-controller/authorization/rbac.go b/internal/operator-controller/authorization/rbac.go
@@ -72,7 +72,6 @@ func NewRBACPreAuthorizer(cl client.Client) PreAuthorizer {
 //     the list (or slice) of missing rules. Note that in some cases the error may encapsulate multiple
 //     evaluation failures
 func (a *rbacPreAuthorizer) PreAuthorize(ctx context.Context, ext *ocv1.ClusterExtension, manifestReader io.Reader) ([]ScopedPolicyRules, error) {
-	var allMissingPolicyRules []ScopedPolicyRules
 	dm, err := a.decodeManifest(manifestReader)
 	if err != nil {
 		return nil, err
@@ -95,6 +94,7 @@ func (a *rbacPreAuthorizer) PreAuthorize(ctx context.Context, ext *ocv1.ClusterE
 			preAuthEvaluationErrors = append(preAuthEvaluationErrors, err)
 		}
 	}
+	allMissingPolicyRules := make([]ScopedPolicyRules, 0, len(missingRules))
 
 	for ns, nsMissingRules := range missingRules {
 		// NOTE: Although CompactRules is defined to return an error, its current implementation

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,6 @@ func NewRBACPreAuthorizer(cl client.Client) PreAuthorizer {`
`72`	`72`	`// the list (or slice) of missing rules. Note that in some cases the error may encapsulate multiple`
`73`	`73`	`// evaluation failures`
`74`	`74`	`func (a rbacPreAuthorizer) PreAuthorize(ctx context.Context, ext ocv1.ClusterExtension, manifestReader io.Reader) ([]ScopedPolicyRules, error) {`
`75`		`- var allMissingPolicyRules []ScopedPolicyRules`
`76`	`75`	`dm, err := a.decodeManifest(manifestReader)`
`77`	`76`	`if err != nil {`
`78`	`77`	`return nil, err`
`@@ -95,6 +94,7 @@ func (a rbacPreAuthorizer) PreAuthorize(ctx context.Context, ext ocv1.ClusterE`
`95`	`94`	`preAuthEvaluationErrors = append(preAuthEvaluationErrors, err)`
`96`	`95`	`}`
`97`	`96`	`}`
	`97`	`+ allMissingPolicyRules := make([]ScopedPolicyRules, 0, len(missingRules))`
`98`	`98`
`99`	`99`	`for ns, nsMissingRules := range missingRules {`
`100`	`100`	`// NOTE: Although CompactRules is defined to return an error, its current implementation`