fix: Ensure logger is initialized before logging errors

camilamacedo86 · camilamacedo86 · commit dbd61828137d · 2025-02-14T14:30:41.000Z
Fixes a silent error in operator-controller where logs were not printed
because the logger was not initialized before usage.
diff --git a/cmd/operator-controller/main.go b/cmd/operator-controller/main.go
@@ -136,6 +136,8 @@ func main() {
 		os.Exit(0)
 	}
 
+	ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig()))
+
 	if (certFile != "" && keyFile == "") || (certFile == "" && keyFile != "") {
 		setupLog.Error(errors.New("missing TLS configuration"),
 			"tls-cert and tls-key flags must be used together",
@@ -154,8 +156,6 @@ func main() {
 		metricsAddr = ":8443"
 	}
 
-	ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig()))
-
 	setupLog.Info("starting up the controller", "version info", version.String())
 
 	authFilePath := filepath.Join(os.TempDir(), fmt.Sprintf("%s-%s.json", authFilePrefix, apimachineryrand.String(8)))

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,8 @@ func main() {`
`136`	`136`	`os.Exit(0)`
`137`	`137`	`}`
`138`	`138`
	`139`	`+ ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig()))`
	`140`	`+`
`139`	`141`	`if (certFile != "" && keyFile == "") \|\| (certFile == "" && keyFile != "") {`
`140`	`142`	`setupLog.Error(errors.New("missing TLS configuration"),`
`141`	`143`	`"tls-cert and tls-key flags must be used together",`
`@@ -154,8 +156,6 @@ func main() {`
`154`	`156`	`metricsAddr = ":8443"`
`155`	`157`	`}`
`156`	`158`
`157`		`- ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig()))`
`158`		`-`
`159`	`159`	`setupLog.Info("starting up the controller", "version info", version.String())`
`160`	`160`
`161`	`161`	`authFilePath := filepath.Join(os.TempDir(), fmt.Sprintf("%s-%s.json", authFilePrefix, apimachineryrand.String(8)))`