Fixup synthetic service account name

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

internal/operator-controller/action/restconfig.go

@@ -14,7 +14,7 @@ import (
 	"github.com/operator-framework/operator-controller/internal/operator-controller/features"
 )
 
-const syntheticServiceAccountName = "olm:synthetic-user"
+const syntheticServiceAccountName = "olm.synthetic-user"
 
 type clusterExtensionRestConfigMapper struct {
 	saRestConfigMapper        func(ctx context.Context, o client.Object, c *rest.Config) (*rest.Config, error)

internal/operator-controller/action/restconfig_test.go

@@ -44,13 +44,13 @@ func TestMapper_SyntheticPermissionsEnabled(t *testing.T) {
 		fgEnabled          bool
 	}{
 		{
-			description:        "user service account wrapper if extension service account is _not_ called olm:synthetic-user",
-			serviceAccountName: "_not_:olm:synthetic-user",
+			description:        "user service account wrapper if extension service account is _not_ called olm.synthetic-user",
+			serviceAccountName: "not.olm.synthetic-user",
 			expectedMapper:     saAccountWrapper,
 			fgEnabled:          true,
 		}, {
-			description:        "user synthetic user wrapper is extension service account is called olm:synthetic-user",
-			serviceAccountName: "olm:synthetic-user",
+			description:        "user synthetic user wrapper is extension service account is called olm.synthetic-user",
+			serviceAccountName: "olm.synthetic-user",
 			expectedMapper:     synthUserWrapper,
 			fgEnabled:          true,
 		},
@@ -80,7 +80,7 @@ func TestMapper_SyntheticPermissionsDisabled(t *testing.T) {
 	ext := &ocv1.ClusterExtension{
 		Spec: ocv1.ClusterExtensionSpec{
 			ServiceAccount: ocv1.ServiceAccountReference{
-				Name: "olm:synthetic-user",
+				Name: "olm.synthetic-user",
 			},
 		},
 	}

internal/operator-controller/authentication/synthetic.go

@@ -14,7 +14,7 @@ func SyntheticUserName(ext ocv1.ClusterExtension) string {
 
 func SyntheticGroups(_ ocv1.ClusterExtension) []string {
 	return []string{
-		"olmv1:clusterextensions",
+		"olm:clusterextensions",
 		"system:authenticated",
 	}
 }

internal/operator-controller/authentication/synthetic_test.go

@@ -22,7 +22,7 @@ func TestSyntheticUserName(t *testing.T) {
 func TestSyntheticGroups(t *testing.T) {
 	syntheticGroups := authentication.SyntheticGroups(ocv1.ClusterExtension{})
 	require.Equal(t, []string{
-		"olmv1:clusterextensions",
+		"olm:clusterextensions",
 		"system:authenticated",
 	}, syntheticGroups)
 }
@@ -35,7 +35,7 @@ func TestSyntheticImpersonationConfig(t *testing.T) {
 	})
 	require.Equal(t, "olm:clusterextensions:my-ext", config.UserName)
 	require.Equal(t, []string{
-		"olmv1:clusterextensions",
+		"olm:clusterextensions",
 		"system:authenticated",
 	}, config.Groups)
 	require.Empty(t, config.UID)