Fix Boxcutter manifest ordering inconsistency (#2329)

Issue:
Manifest ordering inconsistency: CRDs from Helm release manifest and
bundle manifest appeared in different orders, causing PhaseSort to
produce different phase structures even though they contained the same
objects.

Solution:
Added deterministic sorting in PhaseSort (phase.go):
 - Sort objects within each phase by Group, Version, Kind, Namespace, Name
 - Ensures consistent phase structure regardless of input order
 - Critical for comparing revisions from different sources

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Todd Short <[email protected]>
Co-authored-by: Claude <[email protected]>

Author: tmshort

internal/operator-controller/applier/phase.go

@@ -1,6 +1,9 @@
 package applier
 
 import (
+	"cmp"
+	"slices"
+
 	"k8s.io/apimachinery/pkg/runtime/schema"
 
 	ocv1 "github.com/operator-framework/operator-controller/api/v1"
@@ -111,6 +114,23 @@ func init() {
 	}
 }
 
+// Sort objects within the phase deterministically by Group, Version, Kind, Namespace, Name
+// to ensure consistent ordering regardless of input order. This is critical for
+// Helm-to-Boxcutter migration where the same resources may come from different sources
+// (Helm release manifest vs bundle manifest) and need to produce identical phases.
+func compareClusterExtensionRevisionObjects(a, b ocv1.ClusterExtensionRevisionObject) int {
+	aGVK := a.Object.GroupVersionKind()
+	bGVK := b.Object.GroupVersionKind()
+
+	return cmp.Or(
+		cmp.Compare(aGVK.Group, bGVK.Group),
+		cmp.Compare(aGVK.Version, bGVK.Version),
+		cmp.Compare(aGVK.Kind, bGVK.Kind),
+		cmp.Compare(a.Object.GetNamespace(), b.Object.GetNamespace()),
+		cmp.Compare(a.Object.GetName(), b.Object.GetName()),
+	)
+}
+
 // PhaseSort takes an unsorted list of objects and organizes them into sorted phases.
 // Each phase will be applied in order according to DefaultPhaseOrder. Objects
 // within a single phase are applied simultaneously.
@@ -125,6 +145,9 @@ func PhaseSort(unsortedObjs []ocv1.ClusterExtensionRevisionObject) []ocv1.Cluste
 
 	for _, phaseName := range defaultPhaseOrder {
 		if objs, ok := phaseMap[phaseName]; ok {
+			// Sort objects within the phase deterministically
+			slices.SortFunc(objs, compareClusterExtensionRevisionObjects)
+
 			phasesSorted = append(phasesSorted, ocv1.ClusterExtensionRevisionPhase{
 				Name:    string(phaseName),
 				Objects: objs,