Skip to content

Commit f88400c

Browse files
authored
Remove nil/blank checks for installed bundle labels (#1405)
These checks were only needed for the upgrade-e2e Signed-off-by: Todd Short <[email protected]>
1 parent 1cb254c commit f88400c

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

internal/controllers/clusterextension_controller.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -493,14 +493,6 @@ func (d *DefaultInstalledBundleGetter) GetInstalledBundle(ctx context.Context, e
493493
// But we need to look for the most-recent _Deployed_ release
494494
for _, rel := range relhis {
495495
if rel.Info != nil && rel.Info.Status == release.StatusDeployed {
496-
// If there are blank values, we should consider this as not installed
497-
if n, ok := rel.Labels[labels.BundleNameKey]; !ok || n == "" {
498-
return nil, nil
499-
}
500-
if v, ok := rel.Labels[labels.BundleVersionKey]; !ok || v == "" {
501-
return nil, nil
502-
}
503-
// Not checking BundleReferenceKey, as it's new; upgrade test would fail
504496
return &InstalledBundle{
505497
BundleMetadata: ocv1alpha1.BundleMetadata{
506498
Name: rel.Labels[labels.BundleNameKey],

0 commit comments

Comments
 (0)