-
Notifications
You must be signed in to change notification settings - Fork 67
Closed as not planned
Labels
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.
Description
In a recent sync call on slack, we identified that our current InstalledBundleGetter
doesn't return sufficient information to give us a clear picture to determine the appropriate Installed
condition state.
After #1296 is fixed, we can implement the following behavior for the Installed
condition to adhere to the level-based approach that is expected of Kubernetes controllers:
- If we get a
nil
value and no error from theInstalledBundleGetter
- nothing installed (i.eInstalled
==False
) - If we get an error from the
InstalledBundleGetter
-Installed
condition is set toUnknown
- If we get a non-nil value from the
InstalledBundleGetter
and an error happens in a step leading to successful upgrade,Installed
condition set toTrue
andProgressing
condition contains the upgrade failure
Metadata
Metadata
Assignees
Labels
lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.