Skip to content

Release leader election lease on shutdown #1687

@joelanford

Description

@joelanford

In #1683, we fixed an issue related to flaky upgrade e2e tests that were a result of longer election times caused by #1663 (which was an intentional change to be tolerant to longer periods of apiserver downtime or heavy load)

As part of 1683, we bumped a test timeout to account for the new leader election settings.

My spidey sense always goes off when I see a timeout get bumped up in our tests. After some disucssion with other maintainers, I propose that we:

  1. Revert the change to the upgrade e2e test (i.e. test/upgrade-e2e/post_upgrade_test.go) from 1683.
  2. Set LeaderElectionReleaseOnCancel: true in our manager options for both catalogd and operator-controller.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/flakeCategorizes issue or PR as related to a flaky test.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions