Skip to content

Conversation

@bentito
Copy link
Contributor

@bentito bentito commented Sep 18, 2024

Reordered sections and added MacOS setup into a dedicated section. Improved structure for better readability and provided clear instructions for installing and using necessary tools.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Reordered sections and added MacOS setup into a dedicated section. Improved structure for better readability and provided clear instructions for installing and using necessary tools.

Signed-off-by: Brett Tofel <[email protected]>
@bentito bentito requested a review from a team as a code owner September 18, 2024 13:27
@netlify
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2aa40b4
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66ec78bdea6dfe0008492485
😎 Deploy Preview https://deploy-preview-1279--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (06424ef) to head (2aa40b4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   76.49%   76.51%   +0.01%     
==========================================
  Files          39       39              
  Lines        2361     2363       +2     
==========================================
+ Hits         1806     1808       +2     
  Misses        389      389              
  Partials      166      166              
Flag Coverage Δ
e2e 57.93% <ø> (+0.03%) ⬆️
unit 52.94% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trgeiger trgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nice changes. I left a few suggestions.

@bentito bentito changed the title Reorganize developer documentation 📖 [Docs] Reorganize developer documentation Sep 18, 2024
Signed-off-by: Brett Tofel <[email protected]>
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@everettraven everettraven added this pull request to the merge queue Sep 19, 2024
Merged via the queue into operator-framework:main with commit f3e2ce0 Sep 19, 2024
18 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants