Skip to content

📖 : Release: Add backport policy #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

📖 : Release: Add backport policy #1641

merged 2 commits into from
Feb 4, 2025

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 21, 2025 •
edited
Loading

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 21, 2025 15:48
@camilamacedo86 camilamacedo86 changed the title doc: Release: Add backport policy 📖 : Release: Add backport policy Jan 21, 2025
@netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit fa69bde
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/679a690822b77d0008978720
😎 Deploy Preview https://deploy-preview-1641--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (a19f91a) to head (fa69bde).
Report is 34 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1641      +/-   ##
==========================================
+ Coverage   67.42%   68.69%   +1.27%     
==========================================
  Files          55       59       +4     
  Lines        4632     5322     +690     
==========================================
+ Hits         3123     3656     +533     
- Misses       1284     1400     +116     
- Partials      225      266      +41
Flag Coverage Δ
e2e 55.74% <ø> (+2.44%) ⬆️
unit 55.76% <ø> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

azych
azych approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@azych azych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2025

@azych: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86
Copy link
Contributor Author

/hold

Up we have the LGTM at in the RFC
But please feel free to review !!!
I appreciate a lot your help and time on reviews for we shape it.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
@camilamacedo86 camilamacedo86 force-pushed the backport-policy branch 2 times, most recently from 5386c97 to 0e09474 Compare January 23, 2025 14:12
joelanford
joelanford reviewed Jan 24, 2025
View reviewed changes
LalatenduMohanty
LalatenduMohanty requested changes Jan 28, 2025
View reviewed changes
LalatenduMohanty
LalatenduMohanty requested changes Jan 28, 2025
View reviewed changes
joelanford
joelanford previously approved these changes Jan 29, 2025
View reviewed changes
LalatenduMohanty
LalatenduMohanty requested changes Jan 29, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Jan 29, 2025
View reviewed changes
@camilamacedo86
doc: Release: Add backport policy
f1a6e78 
Add Policy discussed and agreed between maintainers
camilamacedo86
camilamacedo86 commented Jan 29, 2025
View reviewed changes
camilamacedo86
camilamacedo86 commented Jan 29, 2025
View reviewed changes
RELEASE.md

## Backporting Policy

Significant security and critical bug fixes can be backported to the most recent minor release.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LalatenduMohanty wdyt now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

LalatenduMohanty
LalatenduMohanty approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@camilamacedo86
Copy link
Contributor Author

I am removing the hold here
/hold cancel

We seem to have enough convey, but if someone wants to propose changes to it, please feel free.
We can always do a follow-up.

@camilamacedo86 camilamacedo86 reopened this Feb 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into operator-framework:main with commit 68b500b Feb 4, 2025
35 checks passed
@camilamacedo86 camilamacedo86 deleted the backport-policy branch February 6, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@joelanford joelanford Awaiting requested review from joelanford

+1 more reviewer

@azych azych azych approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camilamacedo86 @joelanford @LalatenduMohanty @azych