Skip to content

Commit 03a7f6b

Browse files
author
Jeff Peeler
committed
fix(unit): fix flake in TestUpdate
While polling if the CSV is not found in the lister, make sure to return no error so that the polling continues.
1 parent 84c8914 commit 03a7f6b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/controller/operators/olm/operator_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
apiextensionsfake "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/fake"
2828
aextv1beta1 "k8s.io/apiextensions-apiserver/pkg/client/informers/externalversions"
2929
"k8s.io/apimachinery/pkg/api/equality"
30+
k8serrors "k8s.io/apimachinery/pkg/api/errors"
3031
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3132
"k8s.io/apimachinery/pkg/labels"
3233
"k8s.io/apimachinery/pkg/runtime"
@@ -3248,6 +3249,9 @@ func TestUpdates(t *testing.T) {
32483249
if expectedCurrent != expectedPrevious {
32493250
err = wait.PollImmediate(1*time.Millisecond, 5*time.Second, func() (bool, error) {
32503251
updated, err := op.lister.OperatorsV1alpha1().ClusterServiceVersionLister().ClusterServiceVersions(namespace).Get(csv.GetName())
3252+
if k8serrors.IsNotFound(err) {
3253+
return false, nil
3254+
}
32513255
return !equality.Semantic.DeepEqual(updated, fetched), err
32523256
})
32533257
require.NoError(t, err)

0 commit comments

Comments
 (0)