Skip to content

Commit 2272906

Browse files
Merge pull request #523 from ecordell/dont-annotate-immediately
fix(olm): don't annotate namespaces on operator creation
2 parents a35a3a1 + 3d82521 commit 2272906

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

pkg/controller/operators/olm/operator.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,6 @@ func NewOperator(crClient versioned.Interface, opClient operatorclient.ClientInt
8686
op.RegisterQueueInformer(queueInformer)
8787
}
8888

89-
// annotate namespaces that ALM operator manages
90-
if err := namespaceAnnotator.AnnotateNamespaces(namespaces); err != nil {
91-
return nil, err
92-
}
93-
9489
// set up RBAC informers
9590
informerFactory := informers.NewSharedInformerFactory(opClient.KubernetesInterface(), wakeupInterval)
9691
roleInformer := informerFactory.Rbac().V1().Roles()

test/e2e/e2e-values-shift.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ package:
2222
ref: quay.io/coreos/olm:local
2323
pullPolicy: Always
2424
service:
25-
internalPort: 443
25+
internalPort: 5443
2626
commandArgs: -test.coverprofile=/tmp/catalog-coverage.cov
2727

2828
e2e:

test/e2e/e2e-values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ package:
2424
ref: quay.io/coreos/olm:local
2525
pullPolicy: IfNotPresent
2626
service:
27-
internalPort: 443
27+
internalPort: 5443
2828
commandArgs: -test.coverprofile=/tmp/catalog-coverage.cov
2929

3030
e2e:

0 commit comments

Comments
 (0)