Changes based on PR feedback:

- always update test/e2e/assets/chart/zz_chart.go
- simplify sed command

Signed-off-by: John Hunkins <[email protected]>

Author: jchunkins

Makefile

@@ -143,7 +143,8 @@ e2e-local: bin/e2e-local.test test/e2e-local.image.tar
 	$(GINKGO) -nodes $(or $(NODES),1) -flakeAttempts 3 -randomizeAllSpecs $(if $(TEST),-focus '$(TEST)') -v -timeout 90m $< -- -namespace=operators -olmNamespace=operator-lifecycle-manager -dummyImage=bitnami/nginx:latest -kind.images=../test/e2e-local.image.tar
 
 # this target updates the zz_chart.go file with files found in deploy/chart
-# will only fire if a file in deploy/chart has been changed
+# this will always fire since it has been marked as phony
+.PHONY: test/e2e/assets/chart/zz_chart.go
 test/e2e/assets/chart/zz_chart.go: $(shell find deploy/chart -type f)
 	$(BINDATA) -o $@ -pkg chart -prefix deploy/chart/ $^
 

scripts/package_release.sh

@@ -18,13 +18,8 @@ charttmpdir=${charttmpdir}/chart
 
 cp -R deploy/chart/ "${charttmpdir}"
 
-# A space character is needed for -i argument in mac BSD sed.
-# GNU sed has a --version argument, and BSD sed does not. 
-# Check for both conditions to be safe for darwin users that override sed with gsed
-if [ -z "${OSTYPE##*"darwin"*}" ] && ! sed --version >/dev/null 2>&1; then
-    SP=" "
-fi
-sed -i"${SP}"'' "s/^[Vv]ersion:.*\$/version: ${version}/" "${charttmpdir}/Chart.yaml"
+# overwrite the destination Chart.yaml file with a modified copy containing the version
+sed "s/^[Vv]ersion:.*\$/version: ${version}/" deploy/chart/Chart.yaml > "${charttmpdir}/Chart.yaml"
 
 mkdir -p "${chartdir}"