Skip to content

Commit 38adfbb

Browse files
Merge pull request #576 from alecmerdler/ALM-809
Propagate Labels from `CatalogSource` to `PackageManifests`
2 parents 08ea39b + 389c290 commit 38adfbb

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

pkg/package-server/provider/inmem.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func NewInMemoryProvider(informers []cache.SharedIndexInformer, queueOperator *q
7676
}
7777

7878
// parsePackageManifestsFromConfigMap returns a list of PackageManifests from a given ConfigMap
79-
func parsePackageManifestsFromConfigMap(cm *corev1.ConfigMap, catalogSourceName, catalogSourceNamespace, catalogSourcePublisher, catalogSourceDisplayName string) ([]packagev1alpha1.PackageManifest, error) {
79+
func parsePackageManifestsFromConfigMap(cm *corev1.ConfigMap, catsrc *operatorsv1alpha1.CatalogSource) ([]packagev1alpha1.PackageManifest, error) {
8080
cmName := cm.GetName()
8181
logger := log.WithFields(log.Fields{
8282
"Action": "Load ConfigMap",
@@ -140,10 +140,10 @@ func parsePackageManifestsFromConfigMap(cm *corev1.ConfigMap, catalogSourceName,
140140
Status: status,
141141
}
142142

143-
manifest.Status.CatalogSource = catalogSourceName
144-
manifest.Status.CatalogSourceNamespace = catalogSourceNamespace
145-
manifest.Status.CatalogSourceDisplayName = catalogSourceDisplayName
146-
manifest.Status.CatalogSourcePublisher = catalogSourcePublisher
143+
manifest.Status.CatalogSource = catsrc.GetName()
144+
manifest.Status.CatalogSourceNamespace = catsrc.GetNamespace()
145+
manifest.Status.CatalogSourceDisplayName = catsrc.Spec.DisplayName
146+
manifest.Status.CatalogSourcePublisher = catsrc.Spec.Publisher
147147

148148
// add all PackageChannel CSVDescriptions
149149
for i, channel := range manifest.Status.Channels {
@@ -170,6 +170,9 @@ func parsePackageManifestsFromConfigMap(cm *corev1.ConfigMap, catalogSourceName,
170170
// set CatalogSource labels
171171
manifest.ObjectMeta.Labels["catalog"] = manifest.Status.CatalogSource
172172
manifest.ObjectMeta.Labels["catalog-namespace"] = manifest.Status.CatalogSourceNamespace
173+
for k, v := range catsrc.GetLabels() {
174+
manifest.ObjectMeta.Labels[k] = v
175+
}
173176

174177
log.Debugf("retrieved packagemanifest %s", manifest.GetName())
175178
manifests = append(manifests, manifest)
@@ -204,7 +207,7 @@ func (m *InMemoryProvider) syncCatalogSource(obj interface{}) error {
204207
}
205208

206209
// parse PackageManifest from ConfigMap
207-
manifests, err = parsePackageManifestsFromConfigMap(cm, catsrc.GetName(), catsrc.GetNamespace(), catsrc.Spec.Publisher, catsrc.Spec.DisplayName)
210+
manifests, err = parsePackageManifestsFromConfigMap(cm, catsrc)
208211
if err != nil {
209212
return fmt.Errorf("failed to load package manifest from config map %s", cm.GetName())
210213
}

0 commit comments

Comments
 (0)