Skip to content

Commit 5dafa75

Browse files
Merge pull request #1729 from jianzhangbjz/catalog
Bug 1870453: Should not compare the digest if cannot the new update pod's imageID
2 parents 1dd1b46 + 948cd34 commit 5dafa75

File tree

1 file changed

+4
-1
lines changed
  • pkg/controller/registry/reconciler

1 file changed

+4
-1
lines changed

pkg/controller/registry/reconciler/grpc.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,10 @@ func (c *GrpcRegistryReconciler) createUpdatePod(source grpcCatalogSourceDecorat
292292
// checkUpdatePodDigest checks update pod to get Image ID and see if it matches the serving (live) pod ImageID
293293
func imageChanged(updatePod *corev1.Pod, servingPods []*corev1.Pod) bool {
294294
updatedCatalogSourcePodImageID := imageID(updatePod)
295-
295+
if updatedCatalogSourcePodImageID == "" {
296+
logrus.WithField("CatalogSource", updatePod.GetName()).Warn("pod status unknown, cannot get the pod's imageID")
297+
return false
298+
}
296299
for _, servingPod := range servingPods {
297300
servingCatalogSourcePodImageID := imageID(servingPod)
298301
if updatedCatalogSourcePodImageID != servingCatalogSourcePodImageID {

0 commit comments

Comments
 (0)