Commit 6838e5e
authored
fix: Make cert-manager optional for secured metrics endpoints (#3706)
**Problem:**
PR #3660 introduced cert-manager as a hard dependency for OLM deployments, causing installation failures when
cert-manager CRDs are not present:
error getting resource "olm/olm-cert" with GVK "cert-manager.io/v1, Kind=Certificate":
no matches for kind "Certificate" in version "cert-manager.io/v1"
This is a breaking change for existing users who don't have cert-manager installed.
**Solution:**
Make secured metrics endpoints an opt-in feature by setting `certManager.enabled: false` by default in Helm values.
Users who want authenticated metrics must explicitly enable cert-manager.
**Changes:**
- Set `certManager.enabled: false` in `deploy/chart/values.yaml`
- Remove `cert-manager-install` dependency from `make run-local`
- Remove `--set certManager.enabled=true` override from `make deploy`
- Remove automatic cert-manager cleanup from `make undeploy`
**Behavior:**
- Default (cert-manager disabled): HTTP metrics on port 8080, no authentication
- Opt-in (`certManager.enabled: true`): HTTPS metrics on port 8443 with authentication/authorization
Fixes the breaking change introduced in #3660 while preserving the secured metrics feature for users who want it.1 parent 9310fcd commit 6838e5e
2 files changed
+2
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
262 | | - | |
263 | 262 | | |
264 | 263 | | |
265 | 264 | | |
| |||
283 | 282 | | |
284 | 283 | | |
285 | 284 | | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | 285 | | |
290 | 286 | | |
291 | 287 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| |||
0 commit comments