Skip to content

Commit 84797e4

Browse files
Merge pull request #2099 from kevinrizza/unpacker-resource-requests
Add resource requests for bundle unpacker
2 parents feddaf0 + 887f316 commit 84797e4

File tree

2 files changed

+74
-0
lines changed

2 files changed

+74
-0
lines changed

pkg/controller/bundle/bundle_unpacker.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
rbacv1 "k8s.io/api/rbac/v1"
1313
"k8s.io/apimachinery/pkg/api/equality"
1414
apierrors "k8s.io/apimachinery/pkg/api/errors"
15+
"k8s.io/apimachinery/pkg/api/resource"
1516
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1617
"k8s.io/client-go/kubernetes"
1718
listersbatchv1 "k8s.io/client-go/listers/batch/v1"
@@ -93,6 +94,12 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
9394
MountPath: "/bundle",
9495
},
9596
},
97+
Resources: corev1.ResourceRequirements{
98+
Requests: corev1.ResourceList{
99+
corev1.ResourceCPU: resource.MustParse("10m"),
100+
corev1.ResourceMemory: resource.MustParse("50Mi"),
101+
},
102+
},
96103
},
97104
},
98105
InitContainers: []corev1.Container{
@@ -106,6 +113,12 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
106113
MountPath: "/util",
107114
},
108115
},
116+
Resources: corev1.ResourceRequirements{
117+
Requests: corev1.ResourceList{
118+
corev1.ResourceCPU: resource.MustParse("10m"),
119+
corev1.ResourceMemory: resource.MustParse("50Mi"),
120+
},
121+
},
109122
},
110123
{
111124
Name: "pull",
@@ -122,6 +135,12 @@ func (c *ConfigMapUnpacker) job(cmRef *corev1.ObjectReference, bundlePath string
122135
MountPath: "/util",
123136
},
124137
},
138+
Resources: corev1.ResourceRequirements{
139+
Requests: corev1.ResourceList{
140+
corev1.ResourceCPU: resource.MustParse("10m"),
141+
corev1.ResourceMemory: resource.MustParse("50Mi"),
142+
},
143+
},
125144
},
126145
},
127146
Volumes: []corev1.Volume{

pkg/controller/bundle/bundle_unpacker_test.go

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
batchv1 "k8s.io/api/batch/v1"
1212
corev1 "k8s.io/api/core/v1"
1313
rbacv1 "k8s.io/api/rbac/v1"
14+
"k8s.io/apimachinery/pkg/api/resource"
1415
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1516
"k8s.io/apimachinery/pkg/runtime"
1617
"k8s.io/client-go/informers"
@@ -215,6 +216,12 @@ func TestConfigMapUnpacker(t *testing.T) {
215216
MountPath: "/bundle",
216217
},
217218
},
219+
Resources: corev1.ResourceRequirements{
220+
Requests: corev1.ResourceList{
221+
corev1.ResourceCPU: resource.MustParse("10m"),
222+
corev1.ResourceMemory: resource.MustParse("50Mi"),
223+
},
224+
},
218225
},
219226
},
220227
InitContainers: []corev1.Container{
@@ -228,6 +235,12 @@ func TestConfigMapUnpacker(t *testing.T) {
228235
MountPath: "/util",
229236
},
230237
},
238+
Resources: corev1.ResourceRequirements{
239+
Requests: corev1.ResourceList{
240+
corev1.ResourceCPU: resource.MustParse("10m"),
241+
corev1.ResourceMemory: resource.MustParse("50Mi"),
242+
},
243+
},
231244
},
232245
{
233246
Name: "pull",
@@ -244,6 +257,12 @@ func TestConfigMapUnpacker(t *testing.T) {
244257
MountPath: "/util",
245258
},
246259
},
260+
Resources: corev1.ResourceRequirements{
261+
Requests: corev1.ResourceList{
262+
corev1.ResourceCPU: resource.MustParse("10m"),
263+
corev1.ResourceMemory: resource.MustParse("50Mi"),
264+
},
265+
},
247266
},
248267
},
249268
Volumes: []corev1.Volume{
@@ -372,6 +391,12 @@ func TestConfigMapUnpacker(t *testing.T) {
372391
MountPath: "/bundle",
373392
},
374393
},
394+
Resources: corev1.ResourceRequirements{
395+
Requests: corev1.ResourceList{
396+
corev1.ResourceCPU: resource.MustParse("10m"),
397+
corev1.ResourceMemory: resource.MustParse("50Mi"),
398+
},
399+
},
375400
},
376401
},
377402
InitContainers: []corev1.Container{
@@ -385,6 +410,12 @@ func TestConfigMapUnpacker(t *testing.T) {
385410
MountPath: "/util",
386411
},
387412
},
413+
Resources: corev1.ResourceRequirements{
414+
Requests: corev1.ResourceList{
415+
corev1.ResourceCPU: resource.MustParse("10m"),
416+
corev1.ResourceMemory: resource.MustParse("50Mi"),
417+
},
418+
},
388419
},
389420
{
390421
Name: "pull",
@@ -401,6 +432,12 @@ func TestConfigMapUnpacker(t *testing.T) {
401432
MountPath: "/util",
402433
},
403434
},
435+
Resources: corev1.ResourceRequirements{
436+
Requests: corev1.ResourceList{
437+
corev1.ResourceCPU: resource.MustParse("10m"),
438+
corev1.ResourceMemory: resource.MustParse("50Mi"),
439+
},
440+
},
404441
},
405442
},
406443
Volumes: []corev1.Volume{
@@ -568,6 +605,12 @@ func TestConfigMapUnpacker(t *testing.T) {
568605
MountPath: "/bundle",
569606
},
570607
},
608+
Resources: corev1.ResourceRequirements{
609+
Requests: corev1.ResourceList{
610+
corev1.ResourceCPU: resource.MustParse("10m"),
611+
corev1.ResourceMemory: resource.MustParse("50Mi"),
612+
},
613+
},
571614
},
572615
},
573616
InitContainers: []corev1.Container{
@@ -581,6 +624,12 @@ func TestConfigMapUnpacker(t *testing.T) {
581624
MountPath: "/util",
582625
},
583626
},
627+
Resources: corev1.ResourceRequirements{
628+
Requests: corev1.ResourceList{
629+
corev1.ResourceCPU: resource.MustParse("10m"),
630+
corev1.ResourceMemory: resource.MustParse("50Mi"),
631+
},
632+
},
584633
},
585634
{
586635
Name: "pull",
@@ -597,6 +646,12 @@ func TestConfigMapUnpacker(t *testing.T) {
597646
MountPath: "/util",
598647
},
599648
},
649+
Resources: corev1.ResourceRequirements{
650+
Requests: corev1.ResourceList{
651+
corev1.ResourceCPU: resource.MustParse("10m"),
652+
corev1.ResourceMemory: resource.MustParse("50Mi"),
653+
},
654+
},
600655
},
601656
},
602657
Volumes: []corev1.Volume{

0 commit comments

Comments
 (0)