Skip to content

Commit 8532945

Browse files
committed
BUG 1238: Fix configmap registry server readiness probe timeouts
Description of the change: The configmap registry server readiness probe was defaulting to 1 second timeout. In cases where cluster/node is a bit slow, the pod goes into CrashBackOff. Increasing the readiness probe initial delay and timeout for the probe itself. The failureThreshold for readiness is 3, this gives it 15 seconds total to get going. Reviewer Checklist + Implementation matches the proposed design, or proposal is updated to match implementation + Sufficient unit test coverage + Sufficient end-to-end test coverage + Docs updated or added to /docs + Commit messages sensible and descriptive Fixes 1238
1 parent 12c06cf commit 8532945

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pkg/controller/registry/reconciler/configmap.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func (s *configMapCatalogSourceDecorator) Service() *v1.Service {
8989
}
9090

9191
func (s *configMapCatalogSourceDecorator) Pod(image string) *v1.Pod {
92-
pod := Pod(s.CatalogSource, "configmap-registry-server", image, s.Labels(), 1, 2)
92+
pod := Pod(s.CatalogSource, "configmap-registry-server", image, s.Labels(), 5, 2)
9393
pod.Spec.ServiceAccountName = s.GetName() + ConfigMapServerPostfix
9494
pod.Spec.Containers[0].Command = []string{"configmap-server", "-c", s.Spec.ConfigMap, "-n", s.GetNamespace()}
9595
ownerutil.AddOwner(pod, s.CatalogSource, false, false)

pkg/controller/registry/reconciler/reconciler.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ func Pod(source *v1alpha1.CatalogSource, name string, image string, labels map[s
118118
},
119119
},
120120
InitialDelaySeconds: readinessDelay,
121+
TimeoutSeconds: 5,
121122
},
122123
LivenessProbe: &v1.Probe{
123124
Handler: v1.Handler{

0 commit comments

Comments
 (0)