Skip to content

Commit 9bc06c7

Browse files
committed
Remove InstallPlan Source, SourceNamespace from UX
InstallPlans no longer rely on a relationship to a single CatalogSource, but calling `kubectl` to get installplans stills refers to the `source` and `sourceNamespace` fields. This pr marks those fields as `omitempty` and removes them as display columns to remove them from the default user experience
1 parent 21160c2 commit 9bc06c7

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

deploy/chart/templates/0000_50_olm_04-installplan.crd.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ spec:
2727
type: string
2828
description: The first CSV in the list of clusterServiceVersionNames
2929
JSONPath: .spec.clusterServiceVersionNames[0]
30-
- name: Source
31-
type: string
32-
description: The catalog source for the specified CSVs.
33-
JSONPath: .spec.source
3430
- name: Approval
3531
type: string
3632
description: The approval mode

manifests/0000_50_olm_04-installplan.crd.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ spec:
2727
type: string
2828
description: The first CSV in the list of clusterServiceVersionNames
2929
JSONPath: .spec.clusterServiceVersionNames[0]
30-
- name: Source
31-
type: string
32-
description: The catalog source for the specified CSVs.
33-
JSONPath: .spec.source
3430
- name: Approval
3531
type: string
3632
description: The approval mode

pkg/api/apis/operators/v1alpha1/installplan_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ const (
2323

2424
// InstallPlanSpec defines a set of Application resources to be installed
2525
type InstallPlanSpec struct {
26-
CatalogSource string `json:"source"`
27-
CatalogSourceNamespace string `json:"sourceNamespace"`
26+
CatalogSource string `json:"source,omitempty"`
27+
CatalogSourceNamespace string `json:"sourceNamespace,omitempty"`
2828
ClusterServiceVersionNames []string `json:"clusterServiceVersionNames"`
2929
Approval Approval `json:"approval"`
3030
Approved bool `json:"approved"`

0 commit comments

Comments
 (0)