Skip to content

Commit 9cb8d1e

Browse files
Merge pull request #987 from jpeeler/local-ns-rename
fix(deploy): change local deploy to use olm namespace
2 parents 586e941 + f6f0d7b commit 9cb8d1e

File tree

5 files changed

+22
-18
lines changed

5 files changed

+22
-18
lines changed

Documentation/install/install.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ Here's an example `values.yaml`
3636
# sets the apiversion to use for rbac-resources. Change to `authorization.openshift.io` for openshift
3737
rbacApiVersion: rbac.authorization.k8s.io
3838
# namespace is the namespace the operators will _run_
39-
namespace: local
39+
namespace: olm
4040
# watchedNamespaces is a comma-separated list of namespaces the operators will _watch_ for OLM resources.
4141
# Omit to enable OLM in all namespaces
42-
watchedNamespaces: local
42+
watchedNamespaces: olm
4343
# catalog_namespace is the namespace where the catalog operator will look for global catalogs.
4444
# entries in global catalogs can be resolved in any watched namespace
45-
catalog_namespace: local
45+
catalog_namespace: olm
4646
# operator_namespace is the namespace where the operator runs
47-
operator_namespace: local
47+
operator_namespace: operators
4848

4949
# OLM operator run configuration
5050
olm:
@@ -98,19 +98,21 @@ apiVersion: operators.coreos.com/v1alpha1
9898
kind: Subscription
9999
metadata:
100100
name: etcd
101-
namespace: local
101+
namespace: olm
102102
spec:
103-
channel: alpha
103+
channel: singlenamespace-alpha
104104
name: etcd
105-
source: rh-operators
105+
source: operatorhubio-catalog
106+
sourceNamespace: olm
106107
---
107108
apiVersion: operators.coreos.com/v1alpha1
108109
kind: Subscription
109110
metadata:
110111
name: prometheus
111-
namespace: local
112+
namespace: olm
112113
spec:
113114
channel: alpha
114115
name: prometheus
115-
source: rh-operators
116+
source: operatorhubio-catalog
117+
sourceNamespace: olm
116118
```

Documentation/install/local-values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
installType: upstream
22
rbacApiVersion: rbac.authorization.k8s.io
3-
namespace: local
3+
namespace: olm
44
writeStatusName: '""'
5-
catalog_namespace: local
6-
operator_namespace: local-operators
5+
catalog_namespace: olm
6+
operator_namespace: operators
77
debug: true
88

99
olm:

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ MOCKGEN := ./scripts/generate_mocks.sh
1414
IMAGE_REPO := quay.io/operator-framework/olm
1515
IMAGE_TAG ?= "dev"
1616
SPECIFIC_UNIT_TEST := $(if $(TEST),-run $(TEST),)
17+
LOCAL_NAMESPACE := "olm"
1718
export GO111MODULE=on
1819

1920
# ART builds are performed in dist-git, with content (but not commits) copied
@@ -75,13 +76,13 @@ run-local: build-linux
7576
. ./scripts/build_local.sh
7677
mkdir -p build/resources
7778
. ./scripts/package_release.sh 1.0.0 build/resources Documentation/install/local-values.yaml
78-
. ./scripts/install_local.sh local build/resources
79+
. ./scripts/install_local.sh $(LOCAL_NAMESPACE) build/resources
7980
rm -rf build
8081

8182
deploy-local:
8283
mkdir -p build/resources
8384
. ./scripts/package_release.sh 1.0.0 build/resources Documentation/install/local-values.yaml
84-
. ./scripts/install_local.sh local build/resources
85+
. ./scripts/install_local.sh $(LOCAL_NAMESPACE) build/resources
8586
rm -rf build
8687

8788
e2e.namespace:

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,12 @@ apiVersion: operators.coreos.com/v1alpha1
9696
kind: Subscription
9797
metadata:
9898
name: etcd
99-
namespace: local
99+
namespace: olm
100100
spec:
101-
channel: alpha
101+
channel: singlenamespace-alpha
102102
name: etcd
103-
source: rh-operators
103+
source: operatorhubio-catalog
104+
sourceNamespace: olm
104105
```
105106
106107
This will keep the etcd `ClusterServiceVersion` up to date as new versions become available in the catalog.

pkg/controller/install/attributes_util_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ func TestToAttributeSet(t *testing.T) {
1414
user := &user.DefaultInfo{
1515
Name: "Jim",
1616
}
17-
namespace := "local"
17+
namespace := "olm"
1818

1919
tests := []struct {
2020
description string

0 commit comments

Comments
 (0)