Skip to content

Commit a3dfaba

Browse files
committed
update e2e test
1 parent 52eb357 commit a3dfaba

File tree

2 files changed

+22
-9
lines changed

2 files changed

+22
-9
lines changed

test/e2e/csv_e2e_test.go

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -461,15 +461,10 @@ var _ = Describe("ClusterServiceVersion", func() {
461461
// TODO: same test but create serviceaccount instead
462462
It("create requirements met CRD", func() {
463463

464-
sa := corev1.ServiceAccount{}
465-
sa.SetName(genName("sa-"))
466-
sa.SetNamespace(testNamespace)
467-
_, err := c.CreateServiceAccount(&sa)
468-
Expect(err).ShouldNot(HaveOccurred(), "could not create ServiceAccount %#v", sa)
469-
464+
saName := genName("sa-")
470465
permissions := []v1alpha1.StrategyDeploymentPermissions{
471466
{
472-
ServiceAccountName: sa.GetName(),
467+
ServiceAccountName: saName,
473468
Rules: []rbacv1.PolicyRule{
474469
{
475470
Verbs: []string{"create"},
@@ -482,7 +477,7 @@ var _ = Describe("ClusterServiceVersion", func() {
482477

483478
clusterPermissions := []v1alpha1.StrategyDeploymentPermissions{
484479
{
485-
ServiceAccountName: sa.GetName(),
480+
ServiceAccountName: saName,
486481
Rules: []rbacv1.PolicyRule{
487482
{
488483
Verbs: []string{"get"},
@@ -551,6 +546,18 @@ var _ = Describe("ClusterServiceVersion", func() {
551546
fetchedCSV, err := fetchCSV(crc, csv.Name, testNamespace, csvPendingChecker)
552547
Expect(err).ShouldNot(HaveOccurred())
553548

549+
sa := corev1.ServiceAccount{}
550+
sa.SetName(saName)
551+
sa.SetNamespace(testNamespace)
552+
sa.SetOwnerReferences([]metav1.OwnerReference{{
553+
Name: fetchedCSV.GetName(),
554+
APIVersion: v1alpha1.ClusterServiceVersionAPIVersion,
555+
Kind: v1alpha1.ClusterServiceVersionKind,
556+
UID: fetchedCSV.GetUID(),
557+
}})
558+
_, err = c.CreateServiceAccount(&sa)
559+
Expect(err).ShouldNot(HaveOccurred(), "could not create ServiceAccount %#v", sa)
560+
554561
crd := apiextensions.CustomResourceDefinition{
555562
ObjectMeta: metav1.ObjectMeta{
556563
Name: crdName,

test/e2e/operator_groups_e2e_test.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1399,7 +1399,7 @@ var _ = Describe("Operator Group", func() {
13991399
Name: role.GetName(),
14001400
},
14011401
}
1402-
_, err = c.CreateServiceAccount(serviceAccount)
1402+
createdServiceAccount, err := c.CreateServiceAccount(serviceAccount)
14031403
require.NoError(GinkgoT(), err)
14041404
defer func() {
14051405
c.DeleteServiceAccount(serviceAccount.GetNamespace(), serviceAccount.GetName(), metav1.NewDeleteOptions(0))
@@ -1425,6 +1425,12 @@ var _ = Describe("Operator Group", func() {
14251425
createdCSV, err := crc.OperatorsV1alpha1().ClusterServiceVersions(opGroupNamespace).Create(context.TODO(), &aCSV, metav1.CreateOptions{})
14261426
require.NoError(GinkgoT(), err)
14271427

1428+
ownerutil.AddNonBlockingOwner(createdServiceAccount, createdCSV)
1429+
err = ownerutil.AddOwnerLabels(createdServiceAccount, createdCSV)
1430+
require.NoError(GinkgoT(), err)
1431+
_, err = c.UpdateServiceAccount(createdServiceAccount)
1432+
require.NoError(GinkgoT(), err)
1433+
14281434
err = ownerutil.AddOwnerLabels(createdRole, createdCSV)
14291435
require.NoError(GinkgoT(), err)
14301436
_, err = c.UpdateRole(createdRole)

0 commit comments

Comments
 (0)