fix: defer RUnlock in AsClients

exdx · exdx · commit b15e91f7395f · 2019-11-08T11:33:57.000-05:00
diff --git a/pkg/controller/registry/grpc/source.go b/pkg/controller/registry/grpc/source.go
@@ -193,6 +193,7 @@ func (s *SourceStore) Remove(key resolver.CatalogKey) error {
 func (s *SourceStore) AsClients(globalNamespace, localNamespace string) map[resolver.CatalogKey]client.Interface {
 	refs := map[resolver.CatalogKey]client.Interface{}
 	s.sourcesLock.RLock()
+	defer s.sourcesLock.RUnlock()
 	for key, source := range s.sources {
 		if !(key.Namespace == globalNamespace || key.Namespace == localNamespace) {
 			continue
@@ -202,7 +203,6 @@ func (s *SourceStore) AsClients(globalNamespace, localNamespace string) map[reso
 		}
 		refs[key] = client.NewClientFromConn(source.Conn)
 	}
-	s.sourcesLock.RUnlock()
 
 	// TODO : remove unhealthy
 	return refs

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,7 @@ func (s *SourceStore) Remove(key resolver.CatalogKey) error {`
`193`	`193`	`func (s *SourceStore) AsClients(globalNamespace, localNamespace string) map[resolver.CatalogKey]client.Interface {`
`194`	`194`	`refs := map[resolver.CatalogKey]client.Interface{}`
`195`	`195`	`s.sourcesLock.RLock()`
	`196`	`+ defer s.sourcesLock.RUnlock()`
`196`	`197`	`for key, source := range s.sources {`
`197`	`198`	`if !(key.Namespace == globalNamespace \|\| key.Namespace == localNamespace) {`
`198`	`199`	`continue`
`@@ -202,7 +203,6 @@ func (s *SourceStore) AsClients(globalNamespace, localNamespace string) map[reso`
`202`	`203`	`}`
`203`	`204`	`refs[key] = client.NewClientFromConn(source.Conn)`
`204`	`205`	`}`
`205`		`- s.sourcesLock.RUnlock()`
`206`	`206`
`207`	`207`	`// TODO : remove unhealthy`
`208`	`208`	`return refs`