fix(deploy): move service creation to new file

This allows the certificates to be created before the deployments that
reference them.

Author: Jeff Peeler

deploy/chart/templates/0000_50_olm_02-services.yaml

@@ -0,0 +1,37 @@
+apiVersion: v1
+kind: Service
+metadata:
+  name: olm-operator-metrics
+  namespace: {{ .Values.namespace }}
+  annotations:
+    service.alpha.openshift.io/serving-cert-secret-name: olm-operator-serving-cert
+  labels:
+    app: olm-operator
+spec:
+  type: ClusterIP
+  ports:
+  - name: https-metrics
+    port: 8081
+    protocol: TCP
+    targetPort: metrics
+  selector:
+    app: olm-operator
+---
+apiVersion: v1
+kind: Service
+metadata:
+  name: catalog-operator-metrics
+  namespace: {{ .Values.namespace }}
+  annotations:
+    service.alpha.openshift.io/serving-cert-secret-name: catalog-operator-serving-cert
+  labels:
+    app: catalog-operator
+spec:
+  type: ClusterIP
+  ports:
+  - name: https-metrics
+    port: 8081
+    protocol: TCP
+    targetPort: metrics
+  selector:
+    app: catalog-operator

deploy/chart/templates/0000_50_olm_19-service-monitor.yaml

@@ -27,22 +27,6 @@ spec:
     matchLabels:
       app: olm-operator
 ---
-apiVersion: v1
-kind: Service
-metadata:
-  name: olm-operator
-  namespace: {{ .Values.namespace }}
-  labels:
-    app: olm-operator
-spec:
-  ports:
-  - name: http-metrics
-    port: 8081
-    protocol: TCP
-    targetPort: http
-  selector:
-    app: olm-operator
----
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
@@ -73,22 +57,6 @@ spec:
     matchLabels:
       app: catalog-operator
 ---
-apiVersion: v1
-kind: Service
-metadata:
-  name: catalog-operator
-  namespace: {{ .Values.namespace }}
-  labels:
-    app: catalog-operator
-spec:
-  ports:
-  - name: http-metrics
-    port: 8081
-    protocol: TCP
-    targetPort: http
-  selector:
-    app: catalog-operator
----
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
@@ -118,4 +86,4 @@ rules:
   verbs:
   - get
   - list
-  - watch
+  - watch