fix(olm): List does not return NotFound error

Jeff Peeler · Jeff Peeler · commit eefcdec6b32d · 2019-07-08T15:31:02.000-04:00
So don't check for an impossible error.
diff --git a/pkg/api/wrappers/deployment_install_client.go b/pkg/api/wrappers/deployment_install_client.go
@@ -123,8 +123,7 @@ func (c *InstallStrategyDeploymentClientForNamespace) FindAnyDeploymentsMatching
 
 func (c *InstallStrategyDeploymentClientForNamespace) FindAnyDeploymentsMatchingLabels(label labels.Selector) ([]*appsv1.Deployment, error) {
 	deployments, err := c.opLister.AppsV1().DeploymentLister().Deployments(c.Namespace).List(label)
-	// Any errors other than !exists are propagated up
-	if err != nil && !apierrors.IsNotFound(err) {
+	if err != nil {
 		return nil, err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,7 @@ func (c *InstallStrategyDeploymentClientForNamespace) FindAnyDeploymentsMatching`
`123`	`123`
`124`	`124`	`func (c InstallStrategyDeploymentClientForNamespace) FindAnyDeploymentsMatchingLabels(label labels.Selector) ([]appsv1.Deployment, error) {`
`125`	`125`	`deployments, err := c.opLister.AppsV1().DeploymentLister().Deployments(c.Namespace).List(label)`
`126`		`- // Any errors other than !exists are propagated up`
`127`		`- if err != nil && !apierrors.IsNotFound(err) {`
	`126`	`+ if err != nil {`
`128`	`127`	`return nil, err`
`129`	`128`	`}`
`130`	`129`