Skip to content

Commit f09b563

Browse files
committed
test(e2e): remove extra resource comparison
Remove extra resource comparison at the end of two tests since eventually consistent orthogonal conditions sometimes cause a false negative.
1 parent 4b50bb5 commit f09b563

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

test/e2e/subscription_e2e_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -452,11 +452,6 @@ func TestCreateNewSubscriptionNotInstalled(t *testing.T) {
452452

453453
_, err = fetchCSV(t, crc, subscription.Status.CurrentCSV, testNamespace, buildCSVConditionChecker(v1alpha1.CSVPhaseSucceeded))
454454
require.NoError(t, err)
455-
456-
// Fetch subscription again to check for unnecessary control loops
457-
sameSubscription, err := fetchSubscription(t, crc, testNamespace, testSubscriptionName, subscriptionStateAtLatestChecker)
458-
require.NoError(t, err)
459-
compareResources(t, subscription, sameSubscription)
460455
}
461456

462457
// I. Creating a new subscription
@@ -484,11 +479,6 @@ func TestCreateNewSubscriptionExistingCSV(t *testing.T) {
484479
require.NotNil(t, subscription)
485480
_, err = fetchCSV(t, crc, subscription.Status.CurrentCSV, testNamespace, buildCSVConditionChecker(v1alpha1.CSVPhaseSucceeded))
486481
require.NoError(t, err)
487-
488-
// check for unnecessary control loops
489-
sameSubscription, err := fetchSubscription(t, crc, testNamespace, testSubscriptionName, subscriptionStateAtLatestChecker)
490-
require.NoError(t, err)
491-
compareResources(t, subscription, sameSubscription)
492482
}
493483

494484
func TestSubscriptionSkipRange(t *testing.T) {

0 commit comments

Comments
 (0)