-
Notifications
You must be signed in to change notification settings - Fork 565
Closed
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.triagedIssue has been considered by a member of the OLM communityIssue has been considered by a member of the OLM community
Description
For subscription, we are now using name to identify the name of the package https://github.com/operator-framework/operator-lifecycle-manager/blob/master/pkg/api/apis/operators/v1alpha1/subscription_types.go#L34 , an example is as follows:
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
name: my-operator-subsription
namespace: marketplace
spec:
channel: <channel-name>
name: my-operator <<<<
source: johndoe-operators
sourceNamespace: marketplaceBut the spec.name is difficult to understand it means the package name, how about rename this to spec.packageName which is more meaningful?
FYI @clyang82
nick4fake
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.triagedIssue has been considered by a member of the OLM communityIssue has been considered by a member of the OLM community