Revert "CVE-2025-27144: pin go-jose/[email protected]" #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dfd0b2b.
camilamacedo86
approved these changes
Apr 24, 2025
|
|
||
| replace ( | ||
| github.com/go-jose/go-jose/v4 => github.com/go-jose/go-jose/v4 v4.0.5 // CVE-2025-27144 | ||
| // controller runtime |
Contributor
There was a problem hiding this comment.
We can just bump in the indirect call.
It has no need for replaces
Contributor
There was a problem hiding this comment.
That was the point... but in this case there is no reference to it anywhere, so we are removing it.
Contributor
|
/retest-required |
Contributor
|
/approve |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3550
go-jose/[email protected] is an indirect-indirect dependency, and does not need to be
replace-ed since it's absent to begin with.