🌱 Disable FailForward bad resource e2e #3572
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description of the change:
While investigating the FailForward e2e test flakyness, I've discovered we have a hot loop in the CSV state graph where non-terminal errors seem to be retried forever. For the FF e2e, there's a bundle with a bad deployment name. This error was not being marked as terminal. While the csv hot looped: Pending -> InstallReady -> Failed -> Pending -> ..., the test detected the failed state and created the catalog with the fixed bundle, which created the flake as the resolved would fail resolution due to non-referenced csvs =S
Bug has been filed here: #3573
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue