Skip to content

✨ add oceanc to approvers #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

✨ add oceanc to approvers #3609

merged 1 commit into from
Jul 9, 2025

Conversation

grokspawn
Copy link
Contributor

Description of the change:
alpha-sort owners and add oceanc to approvers

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@grokspawn
add oceanc to approvers
6ab5bb2 
Signed-off-by: grokspawn <[email protected]>
@openshift-ci openshift-ci bot requested review from dtfranz and perdasilva July 8, 2025 13:54
@grokspawn
Copy link
Contributor Author

verifying that tide/prow is configured correctly so I should not be able to /lgtm my own PR

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

@grokspawn: you cannot LGTM your own PR.

In response to this:

verifying that tide/prow is configured correctly so I should not be able to /lgtm my own PR

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

camilamacedo86
camilamacedo86 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@grokspawn
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5634537 into operator-framework:master Jul 9, 2025
14 checks passed
@grokspawn grokspawn deleted the add-oceanc branch July 10, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@dtfranz dtfranz Awaiting requested review from dtfranz

@perdasilva perdasilva Awaiting requested review from perdasilva

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grokspawn @camilamacedo86