Skip to content

🐛 Make PSA catalog e2e tests more resilient #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2025
Merged

🐛 Make PSA catalog e2e tests more resilient #3645

merged 1 commit into from
Sep 6, 2025

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

A couple of the PSA related e2e tests are flaking due to out of band changes to the namespace between the get and update calls. This PR adds both of those calls into a single Eventually call to guard against that.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@perdasilva perdasilva changed the title 🐛 Make PSA catalog tests more resilient 🐛 Make PSA catalog e2e tests more resilient Sep 6, 2025
Make PSA catalog tests more resilient
f4e5487 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2025
@perdasilva
Copy link
Collaborator Author

Given that it's the weekend and the changes are minor, I will push them through...

@openshift-merge-bot openshift-merge-bot bot merged commit b9e6cce into operator-framework:master Sep 6, 2025
19 of 21 checks passed
@dtfranz
Copy link
Contributor

dtfranz commented Sep 8, 2025

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@joelanford joelanford Awaiting requested review from joelanford

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perdasilva @dtfranz