-
Notifications
You must be signed in to change notification settings - Fork 567
🐛 Fix nil pointer dereference panic in event recorder #3727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Downstream test passed https://pr-payload-tests.ci.openshift.org/runs/ci/a054e3f0-dbef-11f0-9c31-87ae5436edc1-0 |
f40bcd6 to
650704d
Compare
650704d to
36cc1aa
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The related client-go PR: kubernetes/kubernetes#135925 |
|
/lgtm |
|
@jianzhangbjz: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Based on kubernetes/kubernetes#135925 (comment), we should fix this issue in our repo instead of client-go. |
|
Hi @perdasilva , could you help add the |
Description of the change:
Add SafeEventRecorder wrapper that validates objects before recording
events to prevent panics when objects have nil or empty metadata.
This fixes a panic that occurs when recording events for objects
that have been deleted or have incomplete metadata during rapid
reconciliation cycles."
Motivation for the change:
To fix https://issues.redhat.com/browse/OCPBUGS-69688
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issueAssisted-by: Claude Code