Skip to content

Commit 7069213

Browse files
committed
with pointer field/omitempty instead of instance
Signed-off-by: grokspawn <[email protected]>
1 parent 19c4ee4 commit 7069213

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

alpha/declcfg/declcfg_to_model.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ func ConvertToModel(cfg DeclarativeConfig) (model.Model, error) {
147147
mb.Objects = b.Objects
148148
mb.PropertiesP = props
149149
mb.Version = ver
150-
mb.Release = props.Packages[0].Release
150+
if props.Packages[0].Release != nil {
151+
mb.Release = *(props.Packages[0].Release)
152+
}
151153
}
152154
}
153155
if !found {

alpha/property/property.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type Release struct {
4545
type Package struct {
4646
PackageName string `json:"packageName"`
4747
Version string `json:"version"`
48-
Release Release `json:"release,omitzero"`
48+
Release *Release `json:"release,omitempty"`
4949
}
5050

5151
// NOTICE: The Channel properties are for internal use only.
@@ -256,7 +256,7 @@ func MustBuildPackage(name, version string) Property {
256256
return MustBuild(&Package{PackageName: name, Version: version})
257257
}
258258
func MustBuildPackageRelease(name, version, relLabel, relVersion string) Property {
259-
return MustBuild(&Package{PackageName: name, Version: version, Release: Release{Label: relLabel, Version: semver.MustParse(relVersion)}})
259+
return MustBuild(&Package{PackageName: name, Version: version, Release: &Release{Label: relLabel, Version: semver.MustParse(relVersion)}})
260260
}
261261
func MustBuildPackageRequired(name, versionRange string) Property {
262262
return MustBuild(&PackageRequired{name, versionRange})

alpha/property/property_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ func TestBuild(t *testing.T) {
213213
},
214214
{
215215
name: "Success/Package-ReleaseVersion",
216-
input: &Package{PackageName: "name", Version: "0.1.0", Release: Release{Label: "alpha-whatsit", Version: semver.MustParse("1.1.0-bluefoot")}},
216+
input: &Package{PackageName: "name", Version: "0.1.0", Release: &Release{Label: "alpha-whatsit", Version: semver.MustParse("1.1.0-bluefoot")}},
217217
assertion: require.NoError,
218218
expectedProperty: propPtr(MustBuildPackageRelease("name", "0.1.0", "alpha-whatsit", "1.1.0-bluefoot")),
219219
},

0 commit comments

Comments
 (0)