review revisions

Signed-off-by: Jordan Keister <[email protected]>

Author: grokspawn

.golangci.yaml

@@ -24,6 +24,7 @@ linters:
   - errorlint
   - gci
   - gofmt
+  - govet
   - gosec
   - importas
   - misspell

alpha/action/migrate_test.go

@@ -125,7 +125,7 @@ func TestMigrate(t *testing.T) {
 				return
 			}
 			actualFS := os.DirFS(s.migrate.OutputDir)
-			_ = fs.WalkDir(actualFS, ".", func(path string, d fs.DirEntry, err error) error {
+			require.NoError(t, fs.WalkDir(actualFS, ".", func(path string, d fs.DirEntry, err error) error {
 				require.NoError(t, err)
 				if d.IsDir() {
 					return nil
@@ -136,7 +136,7 @@ func TestMigrate(t *testing.T) {
 				require.True(t, ok, "output directory contained unexpected file %q", path)
 				require.Equal(t, expectedData, string(actualData))
 				return nil
-			})
+			}))
 		})
 	}
 }

test/e2e/bundle_image_test.go

@@ -276,7 +276,7 @@ func pushLoadImages(client *kubernetes.Clientset, w io.Writer, images ...string)
 		}
 	} else {
 		for _, image := range images {
-			err = pushWith("docker", image)
+			err := pushWith("docker", image)
 			if err != nil {
 				return err
 			}