add unit tests for channel validation stranding scenarios

Author: joelanford

alpha/model/model_test.go

@@ -156,13 +156,59 @@ func TestValidReplacesChain(t *testing.T) {
 			assertion: hasError(`detected cycle in replaces chain of upgrade graph: anakin.v0.0.3 -> anakin.v0.0.2 -> anakin.v0.0.1 -> anakin.v0.0.3`),
 		},
 		{
-			name: "Error/Stranded",
+			name: "Error/StrandedSkipsBeforeReplaces",
 			ch: Channel{Bundles: map[string]*Bundle{
 				"anakin.v0.0.1": {Name: "anakin.v0.0.1"},
 				"anakin.v0.0.2": {Name: "anakin.v0.0.2", Replaces: "anakin.v0.0.1"},
-				"anakin.v0.0.3": {Name: "anakin.v0.0.3", Skips: []string{"anakin.v0.0.2"}},
+				"anakin.v0.0.3": {Name: "anakin.v0.0.3", Replaces: "anakin.v0.0.2"},
+				"anakin.v0.0.4": {Name: "anakin.v0.0.4", Replaces: "anakin.v0.0.3"},
+				"anakin.v0.0.5": {Name: "anakin.v0.0.5", Replaces: "anakin.v0.0.4", Skips: []string{"anakin.v0.0.3"}},
+			}},
+			assertion: hasError(`channel contains one or more stranded bundles: anakin.v0.0.1, anakin.v0.0.2`),
+		},
+		{
+			name: "Error/StrandedSkipsWithReplaces",
+			ch: Channel{Bundles: map[string]*Bundle{
+				"anakin.v0.0.1": {Name: "anakin.v0.0.1"},
+				"anakin.v0.0.2": {Name: "anakin.v0.0.2", Replaces: "anakin.v0.0.1"},
+				"anakin.v0.0.3": {Name: "anakin.v0.0.3", Replaces: "anakin.v0.0.2"},
+				"anakin.v0.0.4": {Name: "anakin.v0.0.4", Replaces: "anakin.v0.0.3", Skips: []string{"anakin.v0.0.3"}},
+				"anakin.v0.0.5": {Name: "anakin.v0.0.5", Replaces: "anakin.v0.0.4"},
 			}},
-			assertion: hasError(`channel contains one or more stranded bundles: anakin.v0.0.1`),
+			assertion: hasError(`channel contains one or more stranded bundles: anakin.v0.0.1, anakin.v0.0.2`),
+		},
+		{
+			name: "Error/StrandedSkipsAfterReplaces",
+			ch: Channel{Bundles: map[string]*Bundle{
+				"anakin.v0.0.1": {Name: "anakin.v0.0.1"},
+				"anakin.v0.0.2": {Name: "anakin.v0.0.2", Replaces: "anakin.v0.0.1"},
+				"anakin.v0.0.3": {Name: "anakin.v0.0.3", Replaces: "anakin.v0.0.2", Skips: []string{"anakin.v0.0.3"}},
+				"anakin.v0.0.4": {Name: "anakin.v0.0.4", Replaces: "anakin.v0.0.3"},
+				"anakin.v0.0.5": {Name: "anakin.v0.0.5", Replaces: "anakin.v0.0.4"},
+			}},
+			assertion: hasError(`channel contains one or more stranded bundles: anakin.v0.0.1, anakin.v0.0.2`),
+		},
+		{
+			name: "Error/StrandingIsCommutative",
+			ch: Channel{Bundles: map[string]*Bundle{
+				"anakin.v0.0.1": {Name: "anakin.v0.0.1"},
+				"anakin.v0.0.2": {Name: "anakin.v0.0.2", Replaces: "anakin.v0.0.1"},
+				"anakin.v0.0.3": {Name: "anakin.v0.0.3", Replaces: "anakin.v0.0.2"},
+				"anakin.v0.0.4": {Name: "anakin.v0.0.4", Replaces: "anakin.v0.0.3", Skips: []string{"anakin.v0.0.2"}, SkipRange: "<=1.0.1"},
+				"anakin.v0.0.5": {Name: "anakin.v0.0.5", Skips: []string{"anakin.v0.0.4"}},
+			}},
+			assertion: hasError(`channel contains one or more stranded bundles: anakin.v0.0.1, anakin.v0.0.2, anakin.v0.0.3`),
+		},
+		{
+			name: "Success/StrandedSkipsTheTail",
+			ch: Channel{Bundles: map[string]*Bundle{
+				"anakin.v0.0.1": {Name: "anakin.v0.0.1"},
+				"anakin.v0.0.2": {Name: "anakin.v0.0.2", Replaces: "anakin.v0.0.1", Skips: []string{"anakin.v0.0.1"}},
+				"anakin.v0.0.3": {Name: "anakin.v0.0.3", Replaces: "anakin.v0.0.2"},
+				"anakin.v0.0.4": {Name: "anakin.v0.0.4", Replaces: "anakin.v0.0.3"},
+				"anakin.v0.0.5": {Name: "anakin.v0.0.5", Replaces: "anakin.v0.0.4"},
+			}},
+			assertion: require.NoError,
 		},
 	}
 	for _, s := range specs {
@@ -196,7 +242,7 @@ func hasError(expectedError string) require.ErrorAssertionFunc {
 			}
 		}
 		t.Errorf("expected error to be or contain suberror `%s`, got `%s`", expectedError, actualError)
-		t.FailNow()
+		//t.FailNow()
 	}
 }